Skip to content

chore: remove pages router and use app router for /insights pages#18088

Merged
hbjORbj merged 1 commit intomainfrom
chore/app-router-insights
Dec 10, 2024
Merged

chore: remove pages router and use app router for /insights pages#18088
hbjORbj merged 1 commit intomainfrom
chore/app-router-insights

Conversation

@hbjORbj
Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj commented Dec 10, 2024 •
edited
Loading

What does this PR do?

  • Fixes CAL-4869

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

looks like

Screenshot 2024-12-10 at 1 22 02 PM Screenshot 2024-12-10 at 1 22 11 PM

@graphite-app graphite-app Bot requested a review from a team December 10, 2024 16:31
@hbjORbj hbjORbj marked this pull request as draft December 10, 2024 16:31
@dosubot dosubot Bot added the insights area: insights, analytics label Dec 10, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Dec 10, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Dec 10, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/10/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj changed the title chore: remove pages router and use app router for insights pages chore: remove pages router and use app router for /insights pages Dec 10, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 10, 2024

E2E results are ready!

@hbjORbj hbjORbj marked this pull request as ready for review December 10, 2024 17:24
@linear
Copy link
Copy Markdown

linear Bot commented Dec 10, 2024

CAL-4869 Remove Pages Router / Render App Router `/insights`

@hbjORbj hbjORbj enabled auto-merge (squash) December 10, 2024 18:24
@hbjORbj hbjORbj requested review from emrysal, eunjae-lee and zomars and removed request for a team December 10, 2024 19:57
@hbjORbj hbjORbj merged commit af43ede into main Dec 10, 2024
@hbjORbj hbjORbj deleted the chore/app-router-insights branch December 10, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eunjae-lee eunjae-lee Awaiting requested review from eunjae-lee

@emrysal emrysal Awaiting requested review from emrysal

1 more reviewer

@zomars zomars zomars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

consumer core area: core, team members only insights area: insights, analytics ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hbjORbj @zomars @keithwillcode