fix: include app directory in rewrites generation logic + migrate /reschedule pages to App Router#18261
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
dosubot
Bot
added
organizations
hbjORbj
changed the title
zomars
previously approved these changes
Dec 19, 2024
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/19/24)1 reviewer was added to this PR based on Keith Williams's automation. |
CarinaWolli
previously approved these changes
Dec 19, 2024
Contributor
E2E results are ready! |
hbjORbj
changed the title
hbjORbj
changed the title
hbjORbj
changed the title
hbjORbj
commented
Dec 19, 2024
| import { headers, cookies } from "next/headers"; | ||
|
|
||
| import { buildLegacyCtx } from "@lib/buildLegacyCtx"; | ||
| import { getServerSideProps } from "@lib/reschedule/[uid]/getServerSideProps"; | ||
|
|
||
| export const generateMetadata = async () => |
Contributor
Author
There was a problem hiding this comment.
metadata not needed because we redirect users in this route
hbjORbj
commented
Dec 19, 2024
| .sync("pages/**/[^_]*.{tsx,js,ts}", { cwd: __dirname }) | ||
| // Pages found here are excluded from redirects in beforeFiles in next.config.js | ||
| const BEFORE_REWRITE_EXCLUDE_PAGES = (exports.pages = glob | ||
| .sync("{pages,app}/**/[^_]*.{tsx,js,ts}", { cwd: __dirname }) |
Contributor
Author
There was a problem hiding this comment.
- Because
/pagesdirectory no longer hadrescheduleandbooking, these were not excluded from the redirects.
Confirmed that these are included now:
keithwillcode
previously requested changes
Dec 19, 2024
Contributor
keithwillcode
left a comment
keithwillcode
left a comment
There was a problem hiding this comment.
Since this is fixing a regression let’s add tests that ensure it won’t regress in the future.
auto-merge was automatically disabled
December 19, 2024 09:20
Pull request was converted to draft
Contributor
Author
|
@keithwillcode Done! |
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Jan 10, 2025
…schedule pages to App Router (calcom#18261) * chore: app router - /reschedule pages (calcom#18150) * app router - /reschedule pages * add to config.matcher * generateMetdata is not needed * include app directory in rewrites generation logic * make it more readable * make code more elegant * fix * fix * fix * fix * test and refactor
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 20, 2025
…schedule pages to App Router (calcom#18261) * chore: app router - /reschedule pages (calcom#18150) * app router - /reschedule pages * add to config.matcher * generateMetdata is not needed * include app directory in rewrites generation logic * make it more readable * make code more elegant * fix * fix * fix * fix * test and refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
/appdirectory in rewrites generation logic. Previously it only included/pagesdirectory.