Skip to content

fix: plain chat removed from mobile devices#18377

Merged
pumfleet merged 1 commit into
mainfrom
plain-chat-remove-small-screen
Dec 27, 2024
Merged

fix: plain chat removed from mobile devices#18377
pumfleet merged 1 commit into
mainfrom
plain-chat-remove-small-screen

Conversation

@nizzyabi
Copy link
Copy Markdown
Contributor

@nizzyabi nizzyabi commented Dec 26, 2024

What does this PR do?

This PR removes plain chatbot access with mobile users as it takes up too much space

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • [y ] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [y ] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [y ] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

make screen smaller and check if plain chatbot is still there

  • Are there environment variables that should be set? (No)
  • What are the minimal test data to have? (NA)
  • What is expected (happy path) to have (input and output)? (Not being able to see plain chatbot on small devices)
  • Any other important info that could help to test that PR (NA)

Checklist

@graphite-app graphite-app Bot requested review from a team December 26, 2024 21:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 26, 2024 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "plain chat removed from mobile devices". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot Bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Dec 26, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Dec 26, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Dec 26, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/26/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (12/26/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/27/24)

1 label was added to this PR based on Keith Williams's automation.

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 27, 2024 2:20am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 27, 2024 2:20am

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Dec 27, 2024 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@nizzyabi nizzyabi force-pushed the plain-chat-remove-small-screen branch from 791c24a to eee2083 Compare December 27, 2024 02:19
@nizzyabi nizzyabi changed the title plain chat removed from mobile devices fix: plain chat removed from mobile devices Dec 27, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 27, 2024

E2E results are ready!

@pumfleet pumfleet merged commit b48d0e1 into main Dec 27, 2024
@pumfleet pumfleet deleted the plain-chat-remove-small-screen branch December 27, 2024 05:44
emrysal
emrysal reviewed Dec 27, 2024
View reviewed changes
Comment thread apps/web/lib/plain/plainChat.tsx
const pathname = usePathname();
const searchParams = useSearchParams();

const isAppDomain = typeof window !== "undefined" && window.location.hostname === "app.cal.com";
Copy link
Copy Markdown
Contributor

@emrysal emrysal Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible that window is undefined given "use client" is set? Not an issue just an observation

Copy link
Copy Markdown
Contributor Author

@nizzyabi nizzyabi Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how else can we check for the domain within the use effect? any recommendations?

joeauyeung pushed a commit that referenced this pull request Jan 5, 2025
@nizzyabi @joeauyeung
remove yarnlock (#18377)
e367e1a
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Jan 10, 2025
@nizzyabi @MuhammadAimanSulaiman
remove yarnlock (calcom#18377)
3b9fd42
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 20, 2025
@nizzyabi @MuhammadAimanSulaiman
remove yarnlock (calcom#18377)
f1bd640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emrysal emrysal emrysal left review comments

@pumfleet pumfleet pumfleet approved these changes

Assignees

No one assigned

Labels

core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nizzyabi @emrysal @pumfleet @keithwillcode