fix: Route Builder field input looses focus on typing#18381
Merged
Udit-takkar merged 6 commits intoDec 27, 2024
Conversation
Contributor
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
hariombalhara
changed the title
dosubot
Bot
added
routing-forms
keithwillcode
added
core
hariombalhara
changed the title
hariombalhara
commented
Dec 27, 2024
| expect(result2.widgets.text.factory).toBe(textFactory); | ||
| }); | ||
|
|
||
| it("should reuse same component fns for settings - ensures remounting is not happening", () => { |
Member
Author
There was a problem hiding this comment.
This test ensures regression doesn't occur
hariombalhara
force-pushed
the
fix-routing-form-input-component-remounting-on-change
branch
from
155a514 to
1a7f2d6
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/27/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Udit-takkar
previously approved these changes
Dec 27, 2024
…t-component-remounting-on-change
…of github.com:calcom/cal.com into fix-routing-form-input-component-remounting-on-change
Contributor
E2E results are ready! |
Udit-takkar
approved these changes
Dec 27, 2024
Udit-takkar
deleted the
fix-routing-form-input-component-remounting-on-change
branch
joeauyeung
pushed a commit
that referenced
this pull request
Jan 5, 2025
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Jan 10, 2025
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 20, 2025
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the issue mentioned here
This Loom shows it working
Mandatory Tasks (DO NOT REMOVE)