Conversation
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (01/09/25)1 reviewer was added to this PR based on Keith Williams's automation. |
zomars
commented
Jan 9, 2025
Contributor
Author
|
Already matched |
Contributor
E2E results are ready! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
PeerRich
approved these changes
Jan 22, 2025
hbjORbj
approved these changes
Jan 22, 2025
zomars
added a commit
that referenced
this pull request
Jan 24, 2025
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents warnings on environments where Plain is not setup.
This pull request includes several changes to update the environment variable
PLAIN_CHAT_IDtoNEXT_PUBLIC_PLAIN_CHAT_IDand to dynamically import thePlainChatcomponent. The most important changes include modifications to environment variables, API route handling, and component imports.Environment variable updates:
.env.example: ChangedPLAIN_CHAT_IDtoNEXT_PUBLIC_PLAIN_CHAT_ID.turbo.json: Updated the environment variable fromPLAIN_CHAT_IDtoNEXT_PUBLIC_PLAIN_CHAT_ID.API route handling:
apps/web/app/api/plain-hash/route.ts: Updated theappIdto useprocess.env.NEXT_PUBLIC_PLAIN_CHAT_IDinstead ofprocess.env.PLAIN_CHAT_ID.Component imports:
apps/web/lib/app-providers-app-dir.tsx: Changed the import ofPlainChatto usedynamicProvider.apps/web/lib/app-providers.tsx: Changed the import ofPlainChatto usedynamicProvider.apps/web/lib/plain/dynamicProvider.tsx: Added dynamic import logic forPlainChatbased on the presence ofNEXT_PUBLIC_PLAIN_CHAT_ID.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist