Skip to content

fix: requires confirmation for event type atom#18729

Merged
Ryukemeister merged 4 commits intomainfrom
redirect-on-success-for-platform
Jan 22, 2025
Merged

fix: requires confirmation for event type atom#18729
Ryukemeister merged 4 commits intomainfrom
redirect-on-success-for-platform

Conversation

@Ryukemeister
Copy link
Copy Markdown
Contributor

@Ryukemeister Ryukemeister commented Jan 17, 2025

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Jan 17, 2025
@graphite-app graphite-app Bot requested a review from a team January 17, 2025 09:46
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jan 17, 2025 •
edited
Loading

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (01/17/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/22/25)

1 label was added to this PR based on Keith Williams's automation.

ThyMinimalDev
ThyMinimalDev reviewed Jan 17, 2025
View reviewed changes
Comment thread packages/platform/atoms/booker/BookerPlatformWrapper.tsx
Comment on lines +308 to +310
if (!!event.data?.successRedirectUrl) {
window.location.href = event.data.successRedirectUrl;
}
Copy link
Copy Markdown
Contributor

@ThyMinimalDev ThyMinimalDev Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can also be done for useCreateRecurringBooking

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 9:08am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 9:08am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 22, 2025

E2E results are ready!

@Ryukemeister Ryukemeister merged commit 15e7fc1 into main Jan 22, 2025
@Ryukemeister Ryukemeister deleted the redirect-on-success-for-platform branch January 22, 2025 13:02
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
@Ryukemeister @MuhammadAimanSulaiman
fix: requires confirmation for event type atom (calcom#18729)
dc4dbb6 
* redirect on success from event types

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThyMinimalDev ThyMinimalDev ThyMinimalDev approved these changes

Assignees

No one assigned

Labels

core area: core, team members only platform Anything related to our platform plan ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ryukemeister @ThyMinimalDev @keithwillcode