Skip to content

fix: convert People filter on /insights/routing from single select to multi select#18735

Merged
eunjae-lee merged 2 commits intomainfrom
eunjae/cal-5049-change-people-filter-from-single-to-multi-select
Jan 24, 2025
Merged

fix: convert People filter on /insights/routing from single select to multi select#18735
eunjae-lee merged 2 commits intomainfrom
eunjae/cal-5049-change-people-filter-from-single-to-multi-select

Conversation

@eunjae-lee
Copy link
Copy Markdown
Contributor

@eunjae-lee eunjae-lee commented Jan 17, 2025

What does this PR do?

  • Fixes CAL-5049

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Try "People" filter on /insights/routing. You should be able to select more than one person.

@linear
Copy link
Copy Markdown

linear Bot commented Jan 17, 2025

@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 17, 2025
@eunjae-lee eunjae-lee force-pushed the eunjae/cal-5049-change-people-filter-from-single-to-multi-select branch from 544f10a to 4a27aa9 Compare January 17, 2025 17:02
@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 4:53pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 4:53pm

@eunjae-lee eunjae-lee force-pushed the eunjae/cal-5049-change-people-filter-from-single-to-multi-select branch from 4a27aa9 to 68adea7 Compare January 17, 2025 17:06
@eunjae-lee
Copy link
Copy Markdown
Contributor Author

This PR is ready for review, but please do not merge, because this PR is stacked on #18655. I will merge this PR after I merge that.

hbjORbj
hbjORbj previously approved these changes Jan 22, 2025
Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice and clean :D

Base automatically changed from eunjae/cal-5013-improve-team-filter-component to main January 24, 2025 16:38
@eunjae-lee eunjae-lee dismissed hbjORbj’s stale review January 24, 2025 16:38

The base branch was changed.

@eunjae-lee eunjae-lee force-pushed the eunjae/cal-5049-change-people-filter-from-single-to-multi-select branch from 68adea7 to 5e24d21 Compare January 24, 2025 16:42
@eunjae-lee eunjae-lee marked this pull request as ready for review January 24, 2025 16:43
@graphite-app graphite-app Bot requested a review from a team January 24, 2025 16:43
@dosubot dosubot Bot added insights area: insights, analytics routing-forms area: routing forms, routing, forms labels Jan 24, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jan 24, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/24/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@eunjae-lee eunjae-lee enabled auto-merge (squash) January 24, 2025 16:52
@eunjae-lee eunjae-lee merged commit b234b16 into main Jan 24, 2025
@eunjae-lee eunjae-lee deleted the eunjae/cal-5049-change-people-filter-from-single-to-multi-select branch January 24, 2025 17:15
@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only insights area: insights, analytics ready-for-e2e routing-forms area: routing forms, routing, forms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants