Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
hbjORbj
changed the title
WithLayout from /bookings/[status] page
hbjORbj
changed the title
WithLayout from /bookings/[status] pageWithLayout from /bookings/[status] page
dosubot
Bot
added
the
bookings
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/17/25)1 reviewer was added to this PR based on Keith Williams's automation. |
hbjORbj
commented
Jan 17, 2025
| // Pages found here are excluded from redirects in beforeFiles in next.config.js | ||
| let pages = (exports.pages = glob | ||
| .sync("{pages,app}/**/[^_]*.{tsx,js,ts}", { cwd: __dirname }) | ||
| .sync("{pages,app,app/(use-page-wrapper)}/**/[^_]*.{tsx,js,ts}", { cwd: __dirname }) |
Contributor
Author
There was a problem hiding this comment.
including dirs inside app/(use-page-wrapper)
Contributor
E2E results are ready! |
* move /403 and /500 * move /auth/error * move /connect-and-join * move /enterprise * move /maintenance * move /more * move /upgrade
hbjORbj
changed the title
WithLayout from /bookings/[status] pageWithLayout from /bookings/[status] page + 8 low-risk single pages
Merged
3 tasks
…yout-from-bookings-status-page
hbjORbj
commented
Jan 19, 2025
| } | ||
|
|
||
| export default WithLayout({ ServerPage: Error403 }); | ||
| export default Error403; |
Contributor
Author
There was a problem hiding this comment.
all the pages migrated in this PR do not have getServerSideProps, so they are lower-risk pages
hbjORbj
changed the title
WithLayout from /bookings/[status] page + 8 low-risk single pagesWithLayout from /bookings/[status] page + 8 low-risk single pages
hbjORbj
added
performance
…yout-from-bookings-status-page
joeauyeung
approved these changes
Jan 22, 2025
Contributor
joeauyeung
left a comment
joeauyeung
left a comment
There was a problem hiding this comment.
Pages are working as expected
hbjORbj
deleted the
chore/removing-WithLayout-from-bookings-status-page
branch
emrysal
pushed a commit
that referenced
this pull request
Jan 24, 2025
…from `/bookings/[status]` page + 8 low-risk single pages (#18737) * add a layoutfile to use-page-wrapper route group * refactor and move bookings status page to route group * improve logic in pagesAndRewritePaths * fix * add use client directive * chore: remove WithLayout from 8 low-risk single pages (#18745) * move /403 and /500 * move /auth/error * move /connect-and-join * move /enterprise * move /maintenance * move /more * move /upgrade * pass dehydratedState in layout
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
…from `/bookings/[status]` page + 8 low-risk single pages (calcom#18737) * add a layoutfile to use-page-wrapper route group * refactor and move bookings status page to route group * improve logic in pagesAndRewritePaths * fix * add use client directive * chore: remove WithLayout from 8 low-risk single pages (calcom#18745) * move /403 and /500 * move /auth/error * move /connect-and-join * move /enterprise * move /maintenance * move /more * move /upgrade * pass dehydratedState in layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
WithLayoutand relying on a single layout file. We need to migrate all routes that useWithLayoutinto(use-page-wrapper)route group./bookings/[status]+ 8 single pages below to use a common layout (all the pages migrated in this PR do not havegetServerSideProps, so they are lower-risk pages)Mandatory Tasks (DO NOT REMOVE)
How should this be tested?