Conversation
* move /403 and /500 * move /auth/error * move /connect-and-join * move /enterprise * move /maintenance * move /more * move /upgrade
…yout-from-more-multiple-pages
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
hbjORbj
changed the base branch from
main
to
chore/removing-WithLayout-from-bookings-status-page
hbjORbj
changed the base branch from
chore/removing-WithLayout-from-bookings-status-page
to
main
hbjORbj
changed the title
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/18/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (01/18/25)1 reviewer was added to this PR based on Keith Williams's automation. |
Contributor
E2E results are ready! |
hbjORbj
changed the title
…yout-from-bookings-status-page
…to chore/removing-WithLayout-from-more-multiple-pages
hbjORbj
changed the base branch from
main
to
chore/removing-WithLayout-from-bookings-status-page
hbjORbj
changed the title
hbjORbj
added
the
performance
Base automatically changed from
chore/removing-WithLayout-from-bookings-status-page
to
main
January 22, 2025 17:53
eunjae-lee
approved these changes
Jan 23, 2025
Contributor
eunjae-lee
left a comment
eunjae-lee
left a comment
There was a problem hiding this comment.
The change looks beautiful! I've tested a few pages, and they worked well.
hbjORbj
deleted the
chore/removing-WithLayout-from-more-multiple-pages
branch
keithwillcode
pushed a commit
that referenced
this pull request
Jan 27, 2025
…ngs page in App Router (#18747) * add a layoutfile to use-page-wrapper route group * refactor and move bookings status page to route group * improve logic in pagesAndRewritePaths * fix * add use client directive * move /403 and /500 * move /auth/error * move /connect-and-join * move /enterprise * move /maintenance * move /more * move /upgrade * chore: remove WithLayout from 8 low-risk single pages (#18745) * move /403 and /500 * move /auth/error * move /connect-and-join * move /enterprise * move /maintenance * move /more * move /upgrade * move /availability pages * move /event-types pages * move /insights pages * move /apps to use-page-wrapper group * move /getting-started to use-page-wrapper group * move /signup to use-page-wrapper group * move /workflows to use-page-wrapper group * move /video pages to use-page-wrapper group * pass dehydratedState in layout * pass dehydratedState in layout * fix test * fix @test * fix
3 tasks
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
…ngs page in App Router (calcom#18747) * add a layoutfile to use-page-wrapper route group * refactor and move bookings status page to route group * improve logic in pagesAndRewritePaths * fix * add use client directive * move /403 and /500 * move /auth/error * move /connect-and-join * move /enterprise * move /maintenance * move /more * move /upgrade * chore: remove WithLayout from 8 low-risk single pages (calcom#18745) * move /403 and /500 * move /auth/error * move /connect-and-join * move /enterprise * move /maintenance * move /more * move /upgrade * move /availability pages * move /event-types pages * move /insights pages * move /apps to use-page-wrapper group * move /getting-started to use-page-wrapper group * move /signup to use-page-wrapper group * move /workflows to use-page-wrapper group * move /video pages to use-page-wrapper group * pass dehydratedState in layout * pass dehydratedState in layout * fix test * fix @test * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
WithLayoutand relying on a single layout file. We need to migrate all routes that useWithLayoutinto(use-page-wrapper)route group.WithLayoutfrom/bookings/[status]page + 8 low-risk single pages #18737 is merged intomain, rebase this branch on top ofmainMandatory Tasks (DO NOT REMOVE)
How should this be tested?