Skip to content

chore: migrate low-risk 3 /auth pages to App Router#18753

Merged
PeerRich merged 6 commits intomainfrom
chore/migrate-low-risk-3-auth-pages
Jan 21, 2025
Merged

chore: migrate low-risk 3 /auth pages to App Router#18753
PeerRich merged 6 commits intomainfrom
chore/migrate-low-risk-3-auth-pages

Conversation

@hbjORbj
Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj commented Jan 19, 2025

What does this PR do?

  • Migrate /auth/platform/authorize, /auth/oauth2/authorize, /auth/signin to App Router

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Test /auth/platform/authorize, /auth/oauth2/authorize, /auth/signin

@graphite-app graphite-app Bot requested a review from a team January 19, 2025 21:54
@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 10:24pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 10:24pm

@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 19, 2025
@dosubot dosubot Bot added authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in i18n area: i18n, translations labels Jan 19, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jan 19, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/19/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj changed the title chore: migrate low risk 3 auth pages chore: migrate low-risk 3 /auth pages to App Router (/auth/platform/authorize, /auth/oauth2/authorize, /auth/signin) Jan 19, 2025
@hbjORbj hbjORbj changed the title chore: migrate low-risk 3 /auth pages to App Router (/auth/platform/authorize, /auth/oauth2/authorize, /auth/signin) chore: migrate low-risk 3 /auth pages to App Router Jan 19, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 19, 2025

E2E results are ready!

eunjae-lee
eunjae-lee previously approved these changes Jan 20, 2025
Copy link
Copy Markdown
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. I've tested the /auth/signin endpoint.

@PeerRich PeerRich merged commit 0f7ecb3 into main Jan 21, 2025
@PeerRich PeerRich deleted the chore/migrate-low-risk-3-auth-pages branch January 21, 2025 09:41
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
* add i18n string

* Update config.matcher in middleware

* migrate auth/oauth2/authorize

* migrate auth/platform/authorize

* migrate auth/signin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in consumer core area: core, team members only i18n area: i18n, translations ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants