Skip to content

chore: bump libphonenumber-js version to 1.11.18#18757

Merged
alishaz-polymath merged 1 commit intomainfrom
chore/bump-libphonenumber-version
Jan 20, 2025
Merged

chore: bump libphonenumber-js version to 1.11.18#18757
alishaz-polymath merged 1 commit intomainfrom
chore/bump-libphonenumber-version

Conversation

@alishaz-polymath
Copy link
Copy Markdown
Member

What does this PR do?

Bumps libphonenumber version to 1.11.18
Fixes #18703
Removes patch libphonenumber-js-npm-1.10.51-4ff79b15f8.patch and adds libphonenumber-js+1.11.18.patch for latest version. This patch is essential to allow us access isValidPhoneNumber via lazy load of libphonenumber-js

Mandatory Tasks (DO NOT REMOVE)

  • N/A I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app Bot requested a review from a team January 20, 2025 06:32
@github-actions github-actions Bot added booking-page area: booking page, public booking page, booker 🐛 bug Something isn't working labels Jan 20, 2025
@dosubot dosubot Bot added the ⬆️ dependencies Pull requests that update a dependency file label Jan 20, 2025
@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Jan 20, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jan 20, 2025

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (01/20/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/20/25)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Copy Markdown
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested LGTM !!
Verified that phone number +61494311111 is valid plus tried some other india phone numbers. Tried some invalid numbers as well.

Also, tried prefill and then submission without making a change to phone number.

@alishaz-polymath alishaz-polymath enabled auto-merge (squash) January 20, 2025 07:11
@alishaz-polymath alishaz-polymath merged commit 1f91fe8 into main Jan 20, 2025
@alishaz-polymath alishaz-polymath deleted the chore/bump-libphonenumber-version branch January 20, 2025 07:14
@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

booking-page area: booking page, public booking page, booker 🐛 bug Something isn't working core area: core, team members only ⬆️ dependencies Pull requests that update a dependency file enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

libphonenumber-js version out of date. Australian numbers starting with +614943 are not validating in Calcom

3 participants