chore: bump libphonenumber-js version to 1.11.18#18757
Merged
alishaz-polymath merged 1 commit intomainfrom Jan 20, 2025
Merged
Conversation
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (01/20/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (01/20/25)1 label was added to this PR based on Keith Williams's automation. |
3 tasks
hariombalhara
approved these changes
Jan 20, 2025
Member
hariombalhara
left a comment
There was a problem hiding this comment.
Tested LGTM !!
Verified that phone number +61494311111 is valid plus tried some other india phone numbers. Tried some invalid numbers as well.
Also, tried prefill and then submission without making a change to phone number.
Contributor
E2E results are ready! |
3 tasks
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps
libphonenumberversion to 1.11.18Fixes #18703
Removes patch
libphonenumber-js-npm-1.10.51-4ff79b15f8.patchand addslibphonenumber-js+1.11.18.patchfor latest version. This patch is essential to allow us access isValidPhoneNumber via lazy load oflibphonenumber-jsMandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist