Skip to content

feat: add option to disable deleting calendar credentials for CalendarSettings atom#18759

Merged
Ryukemeister merged 3 commits intomainfrom
option-to-disable-removing-calendars-for-calendar-settings-atom
Jan 22, 2025
Merged

feat: add option to disable deleting calendar credentials for CalendarSettings atom#18759
Ryukemeister merged 3 commits intomainfrom
option-to-disable-removing-calendars-for-calendar-settings-atom

Conversation

@Ryukemeister
Copy link
Copy Markdown
Contributor

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Jan 20, 2025
@dosubot dosubot Bot added the ✨ feature New feature or request label Jan 20, 2025
@graphite-app graphite-app Bot requested a review from a team January 20, 2025 10:01
@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 0:49am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 0:49am

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jan 20, 2025

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (01/20/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/22/25)

1 label was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 22, 2025

E2E results are ready!

@Ryukemeister Ryukemeister enabled auto-merge (squash) January 22, 2025 12:50
@Ryukemeister Ryukemeister merged commit 586b353 into main Jan 22, 2025
@Ryukemeister Ryukemeister deleted the option-to-disable-removing-calendars-for-calendar-settings-atom branch January 22, 2025 13:09
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only ✨ feature New feature or request platform Anything related to our platform plan ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants