refactor: better observability in api routes#18810
Merged
Conversation
Contributor
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Contributor
E2E results are ready! |
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (01/22/25)1 reviewer was added to this PR based on Keith Williams's automation. |
keithwillcode
approved these changes
Jan 22, 2025
Contributor
keithwillcode
left a comment
There was a problem hiding this comment.
Amazing. Thank you for taking this over @zomars
emrysal
pushed a commit
that referenced
this pull request
Jan 24, 2025
Co-authored-by: Keith Williams <keithwillcode@gmail.com>
zomars
added a commit
that referenced
this pull request
Jan 24, 2025
Co-authored-by: Keith Williams <keithwillcode@gmail.com>
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
Co-authored-by: Keith Williams <keithwillcode@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
refs #18784
This pull request includes changes to improve error handling and refactor the Sentry integration in API handlers. The most important changes include moving the Sentry wrapping logic to the
defaultResponderfunction and enhancing error handling for TRPC errors.Sentry Integration Refactor:
apps/web/pages/api/book/event.ts: Removed the Sentry wrapping from thehandlerfunction and simplified the export statement. [1] [2]packages/lib/server/defaultResponder.ts: Moved the Sentry wrapping logic into thedefaultResponderfunction, allowing it to conditionally wrap handlers based on theendpointRouteparameter. [1] [2]Error Handling Improvements:
packages/lib/server/getServerErrorFromUnknown.ts: Enhanced thegetServerErrorFromUnknownfunction to handle TRPC errors by mapping them to HTTP status codes and messages. [1] [2]Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist