Skip to content

refactor: bookings failures should be caught faster#18817

Merged
anikdhabal merged 3 commits intomainfrom
e2e/fail-faster-on-bookings
Jan 23, 2025
Merged

refactor: bookings failures should be caught faster#18817
anikdhabal merged 3 commits intomainfrom
e2e/fail-faster-on-bookings

Conversation

@zomars
Copy link
Copy Markdown
Contributor

@zomars zomars commented Jan 22, 2025

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 11:02pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 11:02pm

@zomars zomars requested a review from anikdhabal January 22, 2025 20:42
@graphite-app graphite-app Bot requested a review from a team January 22, 2025 20:42
@keithwillcode keithwillcode added core area: core, team members only foundation labels Jan 22, 2025
@dosubot dosubot Bot added automated-tests area: unit tests, e2e tests, playwright 💻 refactor labels Jan 22, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jan 22, 2025

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (01/22/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 22, 2025 •
edited
Loading

E2E results are ready!

anikdhabal
anikdhabal approved these changes Jan 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anikdhabal anikdhabal merged commit 3765c76 into main Jan 23, 2025
@anikdhabal anikdhabal deleted the e2e/fail-faster-on-bookings branch January 23, 2025 00:22
zomars added a commit that referenced this pull request Jan 24, 2025
@zomars
refactor: bookings failures should be caught faster (#18817)
8c69f8a 
* refactor: bookings failures should be caught faster

* fix for expected failures

* Update booking-pages.e2e.ts
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
@zomars @MuhammadAimanSulaiman
refactor: bookings failures should be caught faster (calcom#18817)
c5afea3 
* refactor: bookings failures should be caught faster

* fix for expected failures

* Update booking-pages.e2e.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anikdhabal anikdhabal anikdhabal approved these changes

Assignees

No one assigned

Labels

automated-tests area: unit tests, e2e tests, playwright core area: core, team members only foundation ready-for-e2e 💻 refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zomars @anikdhabal @keithwillcode