Skip to content

fix: use columnPinning API#18830

Merged
hbjORbj merged 2 commits intomainfrom
eunjae/cal-5060-use-columnpinning-api-instead-of-meta
Jan 23, 2025
Merged

fix: use columnPinning API#18830
hbjORbj merged 2 commits intomainfrom
eunjae/cal-5060-use-columnpinning-api-instead-of-meta

Conversation

@eunjae-lee
Copy link
Copy Markdown
Contributor

@eunjae-lee eunjae-lee commented Jan 23, 2025

What does this PR do?

Use the official columnPinning API from Tanstack Table instead of relying on the custom meta object.

  • Fixes CAL-5060

Org member list (pinned on both left and right side)

Screenshot.2025-01-23.at.14.17.14.mp4

Team member list (pinned on right side)

Screenshot.2025-01-23.at.14.22.40.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Columns are correctly pinned on the following pages:

(FYI, columns are pinned only when >= sm viewport)

@linear
Copy link
Copy Markdown

linear Bot commented Jan 23, 2025

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 5:53pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 5:53pm

@eunjae-lee eunjae-lee force-pushed the eunjae/cal-5060-use-columnpinning-api-instead-of-meta branch from c7583cd to fd792aa Compare January 23, 2025 13:00
@eunjae-lee eunjae-lee marked this pull request as ready for review January 23, 2025 14:20
@graphite-app graphite-app Bot requested review from a team January 23, 2025 14:20
@dosubot dosubot Bot added the 🐛 bug Something isn't working label Jan 23, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jan 23, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/23/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (01/23/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/23/25)

1 label was added to this PR based on Keith Williams's automation.

@socket-security
Copy link
Copy Markdown

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@axiomhq/winston@1.3.1 environment Transitive: network +3 395 kB lukasmalkmus
npm/@calcom/platform-libraries@0.0.2 environment, network, unsafe 0 3.55 MB morgan-calcom
npm/@calcom/platform-libraries@0.0.86 environment, network 0 4.7 MB lauris-cal
npm/@golevelup/ts-jest@0.4.0 None 0 20.1 kB wonderpanda
npm/@microsoft/microsoft-graph-types-beta@0.42.0-preview None 0 3.41 MB microsoftgraph
npm/@nest-lab/throttler-storage-redis@1.0.0 None +2 344 kB jmcdo29
npm/@nestjs/bull@10.2.3 None +2 175 kB nestjscore
npm/@nestjs/cli@10.4.9 Transitive: environment, eval, filesystem, network, shell, unsafe +65 35.7 MB
npm/@nestjs/common@10.4.15 None +5 4.68 MB
npm/@nestjs/config@3.3.0 environment, filesystem +4 4.73 MB nestjscore
npm/@nestjs/core@10.4.15 Transitive: environment, filesystem, network, shell +10 4.9 MB
npm/@nestjs/jwt@10.2.0 None +14 259 kB nestjscore
npm/@nestjs/passport@10.0.3 None 0 21.2 kB nestjscore
npm/@nestjs/platform-express@10.4.15 Transitive: environment, eval, filesystem, network, unsafe +53 1.44 MB
npm/@nestjs/schematics@10.2.3 Transitive: eval, filesystem, network +16 29.9 MB nestjscore
npm/@nestjs/swagger@7.4.2 Transitive: environment, eval, filesystem +6 14.8 MB nestjscore
npm/@nestjs/testing@10.4.15 None +1 90.4 kB
npm/@nestjs/throttler@6.2.1 None 0 208 kB nestjscore
npm/@sentry/nestjs@8.51.0 None 0 83.9 kB sentry-bot
npm/@sentry/nextjs@8.51.0 Transitive: environment, eval, filesystem, network, shell, unsafe +205 157 MB billyvg, evanpurkhiser, haza, ...7 more
npm/@sentry/profiling-node@8.51.0 environment, filesystem, shell +2 3.51 MB sentry-bot
npm/@types/cookie-parser@1.4.8 None 0 5.73 kB types
npm/@types/express@4.17.21 None +8 102 kB types
npm/@types/fs-extra@11.0.4 None +1 42.5 kB types
npm/@types/luxon@3.4.2 None 0 120 kB types
npm/@types/node@20.17.16 🔁 npm/@types/node@16.9.1, npm/@types/node@18.19.74 None +1 2.31 MB types
npm/@types/passport-jwt@3.0.13 None +3 71.9 kB types
npm/@types/supertest@2.0.16 Transitive: filesystem, network +4 160 kB types
npm/body-parser@1.20.3 network Transitive: eval, filesystem, unsafe +27 773 kB ulisesgascon
npm/bull@4.16.5 filesystem, shell Transitive: environment, eval, network, unsafe +14 7.4 MB manast
npm/class-transformer@0.5.1 None 0 776 kB typestack-release-bot
npm/class-validator@0.14.1 None +2 13.5 MB typestack-release-bot
npm/connect@3.7.0 environment, network Transitive: filesystem +11 229 kB dougwilson
npm/cookie-parser@1.4.7 None +2 40.3 kB ulisesgascon
npm/googleapis@84.0.0 Transitive: environment, eval, filesystem, network, shell +39 94.6 MB google-wombot
npm/helmet@7.2.0 None 0 104 kB evanhahn
npm/http-proxy-middleware@2.0.7 network +5 2.69 MB chimurai
npm/http@0.0.1-security None 0 464 B andreeleuterio
npm/ioredis@5.4.2 network +8 868 kB ioredis-robot
npm/jest-date-mock@1.0.10 None 0 11.8 kB atool
npm/jest@29.7.0 Transitive: environment, eval, filesystem, network, shell, unsafe +110 3.59 MB simenb
npm/jsforce@1.11.1 environment, filesystem Transitive: eval, network, shell, unsafe +49 12.5 MB salesforce-releases
npm/memory-cache@0.2.0 None 0 36.7 kB ptarjan
npm/nest-winston@1.10.2 environment +1 71.7 kB gremo
npm/next-api-middleware@1.0.1 Transitive: environment +2 86.2 kB htunnicliff
npm/next-auth@4.24.11 environment, network Transitive: eval, filesystem, shell +56 1.27 GB thvu
npm/next-axiom@0.17.0 environment, network +1 428 kB lukasmalkmus
npm/next-swagger-doc@0.3.6 Transitive: environment, filesystem, network, shell +24 4.89 MB jellydn
npm/next-validations@0.2.1 eval 0 273 kB jellydn
npm/next@13.5.8 Transitive: environment, filesystem +27 1.12 GB rauchg, timneutkens, vercel-release-bot
npm/node-mocks-http@1.16.2 environment, network Transitive: eval, filesystem +13 2.65 MB eugef
npm/passport-jwt@4.0.1 None +14 251 kB themikenicholson
npm/passport@0.7.0 network +3 168 kB jaredhanson
npm/qs-stringify@1.2.1 None 0 5.65 kB goto-bus-stop
npm/querystring@0.2.1 None 0 9.39 kB medikoo
npm/reflect-metadata@0.1.14 None 0 295 kB rbuckton
npm/stripe@15.12.0 network, shell Transitive: eval +17 5.39 MB stripe-bindings
npm/supertest@6.3.4 network Transitive: environment, eval, filesystem +27 1.45 MB titanism
npm/ts-jest@29.2.5 environment, filesystem, unsafe Transitive: eval, network, shell +52 24.5 MB kul
npm/ts-loader@9.5.2 Transitive: filesystem, network +6 23.3 MB blakeembrey, jbrantly, johnnyreilly
npm/tsconfig-paths@4.2.0 environment, filesystem, unsafe +1 219 kB jonaskello
npm/tzdata@1.0.43 None 0 439 kB rogierschouten

🚮 Removed packages: npm/@formkit/auto-animate@1.0.0-beta.5, npm/@types/detect-port@1.3.5, npm/@types/lodash@4.17.14, npm/@types/mime-types@2.1.4, npm/classnames@2.5.1, npm/ical.js@1.5.0

View full report↗︎

@socket-security
Copy link
Copy Markdown

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Known malware npm/http@0.0.1-security
  • Note: Package has been removed from the npm registry due to security concerns. This is a placeholder package published by the npm security team to prevent malicious usage of the package name. The original package likely contained harmful code.
🚫

View full report↗︎

Next steps

What is known malware?

This package is malware. We have asked the package registry to remove it.

It is strongly recommended that malware is removed from your codebase.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/http@0.0.1-security

Copy link
Copy Markdown
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested! Much smoother

@hbjORbj hbjORbj merged commit b304467 into main Jan 23, 2025
@hbjORbj hbjORbj deleted the eunjae/cal-5060-use-columnpinning-api-instead-of-meta branch January 23, 2025 18:25
@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working consumer core area: core, team members only ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants