feat: "cal.isBookingDryRun" to be used for Routing form as well#18832
Merged
hariombalhara merged 1 commit intomainfrom Jan 24, 2025
Merged
feat: "cal.isBookingDryRun" to be used for Routing form as well#18832hariombalhara merged 1 commit intomainfrom
hariombalhara merged 1 commit intomainfrom
Conversation
keithwillcode
added
core
dosubot
Bot
added
routing-forms
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/23/25)1 reviewer was added to this PR based on Keith Williams's automation. |
hariombalhara
force-pushed
the
no-response-stored-in-dry-run
branch
from
4608349 to
e6c521c
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
hariombalhara
force-pushed
the
no-response-stored-in-dry-run
branch
from
e6c521c to
2a12e6b
Compare
hariombalhara
commented
Jan 23, 2025
| formResponse: response, | ||
| fields: serializableForm.fields, | ||
| searchParams: new URLSearchParams(stringify(fieldsResponses)), | ||
| searchParams: new URLSearchParams(stringify(paramsToBeForwardedAsIs)), |
Member
Author
There was a problem hiding this comment.
It is jsut fieldsResponses ensuring that 'cal.isBookingDryRun' is there.
hariombalhara
commented
Jan 23, 2025
| // Cloudflare Turnstile Captcha | ||
| const shouldRenderCaptcha = | ||
| renderCaptcha && CLOUDFLARE_SITE_ID && CLOUDFLARE_USE_TURNSTILE_IN_BOOKER === "1"; | ||
| !process.env.NEXT_PUBLIC_IS_E2E && |
Member
Author
There was a problem hiding this comment.
Found this bug while testing it. In E2e mode the Turnstile component renders null but shouldRenderCaptcha=true was disabling the confirm button.
cc @sean-brydon
Contributor
E2E results are ready! |
3 tasks
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If cal.isBookingDry=true then
It is supported in both Headless Router and Routing Form
Demo loom - Also shows the testing
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?