Merged
Conversation
zomars
added
ready-for-e2e
and removed
core
Contributor
E2E results are ready! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
zomars
commented
Jan 23, 2025
| // we don't want to report Bad Request errors to Sentry / console | ||
| if (!(error.statusCode >= 400 && error.statusCode < 500)) { | ||
| console.error(err); | ||
| console.error(error); |
Contributor
Author
There was a problem hiding this comment.
We were sending unprocessed errors to Sentry. This could cause confusion when debugging.
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (01/23/25)1 reviewer was added to this PR based on Keith Williams's automation. |
Udit-takkar
approved these changes
Jan 24, 2025
zomars
added a commit
that referenced
this pull request
Jan 24, 2025
Signed-off-by: Omar López <zomars@me.com> # Conflicts: # apps/web/playwright/booking-pages.e2e.ts # packages/lib/server/getServerErrorFromUnknown.ts
emrysal
pushed a commit
that referenced
this pull request
Jan 24, 2025
Signed-off-by: Omar López <zomars@me.com>
zomars
added a commit
that referenced
this pull request
Jan 24, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request includes several changes to improve error handling and status code responses in the
defaultResponderandgetServerErrorFromUnknownfunctions, as well as updates to related tests.Error handling improvements:
packages/lib/server/defaultResponder.ts: Modified thedefaultResponderfunction to log and capture theerrorobject instead of the original error.packages/lib/server/getServerErrorFromUnknown.ts: Introduced a newgetStatusCodefunction to map specific error codes to appropriate HTTP status codes and updated thegetServerErrorFromUnknownfunction to use this new method. [1] [2]Test updates:
packages/lib/server/defaultResponder.test.ts: Added new test cases to verify thatdefaultResponderresponds with status code 409 forNoAvailableUsersFoundand with status code 429 for rate limit errors.packages/lib/server/defaultResponder.test.ts: Updated import statements to includeErrorCodeandTRPCError.Booking page test fix:
apps/web/playwright/booking-pages.e2e.ts: Fixed the expected status code for booking the same time slot to be 409 instead of 500.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist