Skip to content

fix: Missing salesforce options in Routing Form#18884

Merged
PeerRich merged 2 commits intomainfrom
fix-salesforce-option-missing-in-routing-form
Jan 27, 2025
Merged

fix: Missing salesforce options in Routing Form#18884
PeerRich merged 2 commits intomainfrom
fix-salesforce-option-missing-in-routing-form

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Jan 25, 2025 •
edited
Loading

What does this PR do?

Fix missing salesforce options in routing form.

Root cause was using wrong schema that intentionally removed types. It is a month old regression but wasn't causing any issues so went undetected.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 2:29pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 2:29pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 25, 2025 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "ensure that apps are sent". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Jan 25, 2025
@hariombalhara hariombalhara force-pushed the fix-salesforce-option-missing-in-routing-form branch from 57500be to c2e9cae Compare January 25, 2025 05:51
@hariombalhara hariombalhara marked this pull request as ready for review January 25, 2025 06:03
@graphite-app graphite-app Bot requested a review from a team January 25, 2025 06:03
@dosubot dosubot Bot added crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid routing-forms area: routing forms, routing, forms labels Jan 25, 2025
hariombalhara
hariombalhara commented Jan 25, 2025
View reviewed changes
Comment thread packages/app-store/routing-forms/pages/route-builder/[...appPages].tsx
}

// Pass app data that works with routing forms
const eventTypeAppMetadata = getEventTypeAppMetadata(eventType.metadata);
Copy link
Copy Markdown
Member Author

@hariombalhara hariombalhara Jan 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As getEventTypeAppMetadata reparses the metadata assuming it as JSON value, this issue started happening.

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jan 25, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/25/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@hariombalhara hariombalhara added the 📉 regressing This used to work. Now it doesn't anymore. label Jan 25, 2025
@hariombalhara hariombalhara changed the title ensure that apps are sent fix: Missing salesforce options in Routing Form Jan 25, 2025
@hariombalhara hariombalhara added High priority Created by Linear-GitHub Sync Urgent Created by Linear-GitHub Sync ready-for-e2e and removed ready-for-e2e labels Jan 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 25, 2025 •
edited
Loading

E2E results are ready!

@PeerRich PeerRich enabled auto-merge (squash) January 27, 2025 14:32
@PeerRich PeerRich merged commit f06bac7 into main Jan 27, 2025
@PeerRich PeerRich deleted the fix-salesforce-option-missing-in-routing-form branch January 27, 2025 14:49
keithwillcode pushed a commit that referenced this pull request Jan 27, 2025
@hariombalhara @PeerRich @keithwillcode
fix: Missing salesforce options in Routing Form (#18884)
751cfba 
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
keithwillcode pushed a commit that referenced this pull request Jan 27, 2025
@hariombalhara @PeerRich @keithwillcode
fix: Missing salesforce options in Routing Form (#18884)
1b9c3ec 
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
@hariombalhara @PeerRich @MuhammadAimanSulaiman
fix: Missing salesforce options in Routing Form (calcom#18884)
2c349a6 
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeerRich PeerRich PeerRich approved these changes

@joeauyeung joeauyeung Awaiting requested review from joeauyeung

Assignees

No one assigned

Labels

core area: core, team members only crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid enterprise area: enterprise, audit log, organisation, SAML, SSO High priority Created by Linear-GitHub Sync ready-for-e2e 📉 regressing This used to work. Now it doesn't anymore. routing-forms area: routing forms, routing, forms Urgent Created by Linear-GitHub Sync

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hariombalhara @PeerRich @keithwillcode