Skip to content

chore: use ColumnFilterType enum#18915

Merged
eunjae-lee merged 1 commit intomainfrom
chore/clean-up-column-filter-types
Jan 27, 2025
Merged

chore: use ColumnFilterType enum#18915
eunjae-lee merged 1 commit intomainfrom
chore/clean-up-column-filter-types

Conversation

@eunjae-lee
Copy link
Copy Markdown
Contributor

@eunjae-lee eunjae-lee commented Jan 27, 2025

What does this PR do?

This PR cleans up string literals by changing ColumnFilterType to an enum.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 3:11pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 3:11pm

@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 27, 2025
@eunjae-lee eunjae-lee force-pushed the chore/clean-up-column-filter-types branch from fc07cb9 to 12e9296 Compare January 27, 2025 14:30
@eunjae-lee eunjae-lee changed the title chore: clean up ColumnFilterType chore: use ColumnFilterType enum Jan 27, 2025
@eunjae-lee eunjae-lee force-pushed the chore/clean-up-column-filter-types branch from 12e9296 to 7e292d9 Compare January 27, 2025 14:39
@eunjae-lee eunjae-lee force-pushed the chore/clean-up-column-filter-types branch from 7e292d9 to 19d6e4e Compare January 27, 2025 14:54
@eunjae-lee eunjae-lee force-pushed the chore/clean-up-column-filter-types branch from 19d6e4e to eaa2e85 Compare January 27, 2025 15:11
@eunjae-lee eunjae-lee marked this pull request as ready for review January 27, 2025 15:23
@graphite-app graphite-app Bot requested a review from a team January 27, 2025 15:23
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jan 27, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/27/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/27/25)

1 label was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

@eunjae-lee eunjae-lee merged commit 61a2a3e into main Jan 27, 2025
@eunjae-lee eunjae-lee deleted the chore/clean-up-column-filter-types branch January 27, 2025 16:13
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants