fix: re-design DateRangeFilter#18924
Merged
eunjae-lee merged 5 commits intomainfrom Jan 29, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
dosubot
Bot
added
insights
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/27/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (01/29/25)1 label was added to this PR based on Keith Williams's automation. |
sean-brydon
reviewed
Jan 27, 2025
Comment on lines
+198
to
+215
| <Command className="w-40"> | ||
| <CommandList> | ||
| {PRESET_OPTIONS.map((option) => ( | ||
| <CommandItem | ||
| key={option.value} | ||
| className={classNames( | ||
| "cursor-pointer justify-between", | ||
| selectedPreset.value === option.value && "bg-emphasis" | ||
| )} | ||
| onSelect={() => { | ||
| updateDateRangeFromPreset(option.value); | ||
| }}> | ||
| <span className="capitalize">{t(option.labelKey, option.i18nOptions)}</span> | ||
| {selectedPreset.value === option.value && <Icon name="check" />} | ||
| </CommandItem> | ||
| ))} | ||
| </CommandList> | ||
| </Command> |
Member
There was a problem hiding this comment.
NIT: Can we double check the styling of this section - seems like we should have a bit of padding and gap between elements <3
Contributor
Author
|
adjusted paddings This PR
Prod (for comparison)
|
sean-brydon
approved these changes
Jan 29, 2025
Contributor
E2E results are ready! |
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
* fix: re-design DateRangeFilter * update style * adjust padding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR re-designs
DateRangeFilter, so that it combines Select and DateRangePicker altogether, and shows DateRangePicker only for "custom" range.Before
Screenshot.2025-01-27.at.17.54.13.mp4
After
Screenshot.2025-01-27.at.17.57.00.mp4
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Test the date range picker on /insights/routing.