fix: managed events with internal notes#18933
Merged
sean-brydon merged 1 commit intomainfrom Jan 28, 2025
Merged
Conversation
sean-brydon
commented
Jan 28, 2025
| {!error && ( | ||
| <div className="mt-5 sm:mt-6"> | ||
| {props.isHost && teamId && ( | ||
| {props.isHost && props.internalNotePresets.length > 0 && ( |
Member
Author
There was a problem hiding this comment.
TeamId isnt always true now for this to be rendered
dosubot
Bot
added
bookings
sean-brydon
commented
Jan 28, 2025
| const { currentOrgDomain } = orgDomainConfig(context.req); | ||
|
|
||
| async function getInternalNotePresets(teamId: number) { | ||
| async function getInternalNotePresets(teamId: number | null) { |
Member
Author
There was a problem hiding this comment.
Skipping data if user is not authed as host to be returned
PeerRich
approved these changes
Jan 28, 2025
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/28/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (01/28/25)1 label was added to this PR based on Keith Williams's automation. |
Contributor
E2E results are ready! |
emrysal
pushed a commit
that referenced
this pull request
Jan 28, 2025
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the implementation of internal notes to work outside of just a "team event type" context. Allows the cancelation reason to transfer across to managed event types and not just specific team events.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Create a managed event type on a team
Create Internal note presets in settings > [team name] > settings
Create a booking on managed event type
Cancel booking > Select internal note or "other"
Cancel booking
Try the same with a normal team event type.
Try again with a normal booking that doesnt have internal notes enabled.
Checklist