Skip to content

fix: API V1 cancellationReason fallback/default and doc update#18946

Merged
keithwillcode merged 2 commits intomainfrom
fix/v1-dep
Jan 28, 2025
Merged

fix: API V1 cancellationReason fallback/default and doc update#18946
keithwillcode merged 2 commits intomainfrom
fix/v1-dep

Conversation

@alishaz-polymath
Copy link
Copy Markdown
Member

@alishaz-polymath alishaz-polymath commented Jan 28, 2025

What does this PR do?

Adds cancellationReason fallback to make sure it satisfies the requirement of cancellationReason for hosts. Also adds an update to the docs.

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Just send a cancellation request via API V1 as host

Checklist

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Jan 28, 2025
@dosubot dosubot Bot added api area: API, enterprise API, access token, OAuth docs area: docs, documentation, cal.com/docs 🐛 bug Something isn't working labels Jan 28, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jan 28, 2025

Graphite Automations

"Add ready-for-e2e label" took an action on this PR • (01/28/25)

1 label was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 28, 2025

E2E results are ready!

@keithwillcode keithwillcode merged commit 2646f57 into main Jan 28, 2025
@keithwillcode keithwillcode deleted the fix/v1-dep branch January 28, 2025 18:52
keithwillcode pushed a commit that referenced this pull request Jan 28, 2025
@alishaz-polymath @keithwillcode
fix: API V1 cancellationReason fallback/default and doc update (#18946)
006201f 
* adds fallback/default cancellationReason

* add doc update
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
@alishaz-polymath @MuhammadAimanSulaiman
fix: API V1 cancellationReason fallback/default and doc update (calco…
9db5eea 
…m#18946)

* adds fallback/default cancellationReason

* add doc update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sean-brydon sean-brydon sean-brydon approved these changes

@keithwillcode keithwillcode Awaiting requested review from keithwillcode

Assignees

No one assigned

Labels

api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working core area: core, team members only docs area: docs, documentation, cal.com/docs enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alishaz-polymath @sean-brydon @keithwillcode