fix: show sort state on column header#18950
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
eunjae-lee
force-pushed
the
fix/show-sort-state-on-column
branch
from
d106375 to
31636e4
Compare
| {header.column.getIsSorted() === "asc" && <Icon name="arrow-up" className="h-4 w-4 shrink-0" />} | ||
| {header.column.getIsSorted() === "desc" && <Icon name="arrow-down" className="h-4 w-4 shrink-0" />} |
There was a problem hiding this comment.
show sorting state
| <div | ||
| className="truncate" | ||
| title={ | ||
| typeof header.column.columnDef.header === "string" ? header.column.columnDef.header : undefined | ||
| }> | ||
| {header.isPlaceholder ? null : flexRender(header.column.columnDef.header, header.getContext())} | ||
| </div> |
There was a problem hiding this comment.
truncate header label, and apply "title" attribute if possible
| fetchNextPage, | ||
| isFetching, | ||
| }); | ||
| const { sorting, setSorting } = useDataTable(); |
There was a problem hiding this comment.
Not directly related to this PR, but this sets states and options within DataTableWrapper, so that we don't have to do this in actual components like UserListTable, RoutingFormResponsesTable, etc.
| enableRowSelection: true, | ||
| columnResizeMode: "onChange", | ||
| debugTable: true, |
There was a problem hiding this comment.
This is already done by resizing.ts
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/28/25)1 reviewer was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
|
Hi @calcom team, I'd like to fix this issue. My Approach:
Relevant Experience:
Timeline: 1-2 days Ready to start! Best, |
4 participants
What does this PR do?
This PR adds sorting state on column headers.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Try sorting on /insights/routing or org member list.