Skip to content

fix: invalid iCal download link must not crash booking page#18966

Merged
hbjORbj merged 1 commit intomainfrom
fix/bookings-page-ical-download-link
Jan 28, 2025
Merged

fix: invalid iCal download link must not crash booking page#18966
hbjORbj merged 1 commit intomainfrom
fix/bookings-page-ical-download-link

Conversation

@hbjORbj
Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj commented Jan 28, 2025

What does this PR do?

  • Screenshot 2025-01-28 at 15 38 23
  • No longer throws, but rather iCal button is hidden in case of invalid iCal download link

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@graphite-app graphite-app Bot requested a review from a team January 28, 2025 20:39
@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Jan 28, 2025 8:39pm
calcom-web-canary ⬜️ Ignored (Inspect) Jan 28, 2025 8:39pm

@hbjORbj hbjORbj changed the title fix: bookings page ical download link fix: invalid iCal download link must not crash booking page Jan 28, 2025
@dosubot dosubot Bot added bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working labels Jan 28, 2025
@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 28, 2025
@hbjORbj hbjORbj enabled auto-merge (squash) January 28, 2025 20:40
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jan 28, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/28/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 28, 2025

E2E results are ready!

@hbjORbj hbjORbj merged commit 9cec970 into main Jan 28, 2025
@hbjORbj hbjORbj deleted the fix/bookings-page-ical-download-link branch January 28, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working consumer core area: core, team members only ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants