fix: eventtype null cant be booked error#18975
Merged
keithwillcode merged 13 commits intomainfrom Jan 29, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
keithwillcode
added
core
Comment on lines
+253
to
+258
| if (isAfterRollingEndDay) | ||
| log.warn("Booking is out of bounds due to rolling period end day.", { | ||
| formattedDate: dateInSystemTz.format(), | ||
| isAfterRollingEndDay, | ||
| endOfRollingPeriodEndDayInBookerTz: periodLimits.endOfRollingPeriodEndDayInBookerTz.format(), | ||
| }); |
Member
Author
There was a problem hiding this comment.
Add detailed logs when booking fails due to attempted booking after the rolling period
Comment on lines
+272
to
+279
| if (isBeforeRangeStart || isAfterRangeEnd) | ||
| log.warn("Booking is out of bounds due to range start and end.", { | ||
| formattedDate: dateInSystemTz.format(), | ||
| isBeforeRangeStart, | ||
| isAfterRangeEnd, | ||
| startOfRangeStartDayInEventTz: periodLimits.startOfRangeStartDayInEventTz.format(), | ||
| endOfRangeEndDayInEventTz: periodLimits.endOfRangeEndDayInEventTz.format(), | ||
| }); |
Member
Author
There was a problem hiding this comment.
Add detailed logs when booking fails due to attempted booking outside of period Range
Comment on lines
+303
to
+339
| ): { isOutOfBounds: boolean; cause: string | null } { | ||
| const isOutOfBoundsByTime = isTimeOutOfBounds({ time, minimumBookingNotice }); | ||
| const periodLimits = calculatePeriodLimits({ | ||
| periodType, | ||
| periodDays, | ||
| periodCountCalendarDays, | ||
| periodStartDate, | ||
| periodEndDate, | ||
| allDatesWithBookabilityStatusInBookerTz: null, // Temporary workaround | ||
| _skipRollingWindowCheck: true, | ||
| eventUtcOffset, | ||
| bookerUtcOffset, | ||
| }); | ||
|
|
||
| const isOutOfBoundsByPeriod = isTimeViolatingFutureLimit({ | ||
| time, | ||
| periodLimits, | ||
| }); | ||
|
|
||
| if (isOutOfBoundsByTime) | ||
| return { | ||
| isOutOfBounds: true, | ||
| cause: "Booking is out of bounds due to minimum booking notice.", | ||
| }; | ||
|
|
||
| if (isOutOfBoundsByPeriod) { | ||
| log.warn(`Booking is out of bounds due to period restrictions - ${periodLimits}`); | ||
| return { | ||
| isOutOfBounds: true, | ||
| cause: "Booking is out of bounds due to period restrictions.", | ||
| }; | ||
| } | ||
|
|
||
| return { | ||
| isOutOfBounds: false, | ||
| cause: null, | ||
| }; |
Member
Author
There was a problem hiding this comment.
Return cause along with isOutOfBounds to have a distinct reason on why a booking failed
|
|
||
| logger.warn({ | ||
| message: `NewBooking: EventType '${eventType.eventName}' cannot be booked at this time.`, | ||
| message: `NewBooking: EventType '${eventType.title}' cannot be booked at this time. Reason: ${cause}`, |
Member
Author
There was a problem hiding this comment.
We also add cause here to have a clearer picture of what the cause of this failure is.
dosubot
Bot
added
event-types
Comment on lines
+254
to
+261
| log.warn( | ||
| "Booking is out of bounds due to rolling period end day.", | ||
| safeStringify({ | ||
| formattedDate: dateInSystemTz.format(), | ||
| isAfterRollingEndDay, | ||
| endOfRollingPeriodEndDayInBookerTz: periodLimits.endOfRollingPeriodEndDayInBookerTz.format(), | ||
| }) | ||
| ); |
Member
Author
There was a problem hiding this comment.
We log all necessary details when user attempts to book after the rolling period
Comment on lines
+276
to
+285
| log.warn( | ||
| "Booking is out of bounds due to range start and end.", | ||
| safeStringify({ | ||
| formattedDate: dateInSystemTz.format(), | ||
| isBeforeRangeStart, | ||
| isAfterRangeEnd, | ||
| startOfRangeStartDayInEventTz: periodLimits.startOfRangeStartDayInEventTz.format(), | ||
| endOfRangeEndDayInEventTz: periodLimits.endOfRangeEndDayInEventTz.format(), | ||
| }) | ||
| ); |
Member
Author
There was a problem hiding this comment.
We log all necessary details when user attempts to book outside the period range
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
keithwillcode
approved these changes
Jan 29, 2025
Graphite Automations"Add ready-for-e2e label" took an action on this PR • (01/29/25)1 label was added to this PR based on Keith Williams's automation. |
Contributor
E2E results are ready! |
keithwillcode
pushed a commit
that referenced
this pull request
Jan 29, 2025
* fix err msg and add more description * improvements * fix cause * add warn logs for when failing to specific limit checks * typefix * safestringify log * improve error * test fix and log min booking notice * adds out of bounds error code * test fix * fix
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
* fix err msg and add more description * improvements * fix cause * add warn logs for when failing to specific limit checks * typefix * safestringify log * improve error * test fix and log min booking notice * adds out of bounds error code * test fix * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist