Skip to content

fix: add check for cal video#19020

Merged
emrysal merged 2 commits intomainfrom
fix/trigger
Jan 31, 2025
Merged

fix: add check for cal video#19020
emrysal merged 2 commits intomainfrom
fix/trigger

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar commented Jan 30, 2025 •
edited
Loading

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

triggerGuestNoShowWebhook | Daily video reference not found in triggerHostNoShow with bookingId 5419428

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A I confirm automated tests are in place that prove my fix is effective or that my feature works.

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Jan 30, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 8:08pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 8:08pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 8:08pm

@dosubot dosubot Bot added the 🐛 bug Something isn't working label Jan 30, 2025
@graphite-app graphite-app Bot requested a review from a team January 30, 2025 19:23
emrysal
emrysal previously approved these changes Jan 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jan 30, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/30/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/30/25)

1 label was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 30, 2025

E2E results are ready!

Udit-takkar
Udit-takkar commented Jan 31, 2025
View reviewed changes
Comment thread packages/features/bookings/lib/handleNewBooking.ts
}

try {
if (isConfirmedByDefault && (booking.location === DailyLocationType || booking.location?.trim() === "")) {
Copy link
Copy Markdown
Contributor Author

@Udit-takkar Udit-takkar Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved this check inside function

@emrysal emrysal merged commit 82b1e68 into main Jan 31, 2025
@emrysal emrysal deleted the fix/trigger branch January 31, 2025 15:00
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
@Udit-takkar @MuhammadAimanSulaiman
fix: add check for cal video (calcom#19020)
634a410 
* fix: add check for cal video

* chore: pass location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emrysal emrysal emrysal approved these changes

Assignees

No one assigned

Labels

🐛 bug Something isn't working core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Udit-takkar @emrysal @keithwillcode