Skip to content

fix: replace filter implementations on /insights#19033

Merged
PeerRich merged 28 commits intomainfrom
eunjae/cal-5076-replace-filter-implementations-on-insights-bookings
Feb 10, 2025
Merged

fix: replace filter implementations on /insights#19033
PeerRich merged 28 commits intomainfrom
eunjae/cal-5076-replace-filter-implementations-on-insights-bookings

Conversation

@eunjae-lee
Copy link
Copy Markdown
Contributor

@eunjae-lee eunjae-lee commented Jan 31, 2025 •
edited
Loading

What does this PR do?

  • Fixes CAL-5076

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

/insights and /insights/routing should work the same way with all the filtering.

@linear
Copy link
Copy Markdown

linear Bot commented Jan 31, 2025

CAL-5076 Replace filter implementations on Insights > Bookings

@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 31, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 4:37pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 4:37pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 4:37pm

@vercel vercel Bot temporarily deployed to Preview – calcom-web-canary February 4, 2025 14:28 Inactive
@vercel vercel Bot temporarily deployed to Preview – api February 4, 2025 14:29 Inactive
@eunjae-lee eunjae-lee force-pushed the eunjae/cal-5076-replace-filter-implementations-on-insights-bookings branch from e896131 to 20c96a0 Compare February 7, 2025 14:17
@eunjae-lee eunjae-lee force-pushed the eunjae/cal-5076-replace-filter-implementations-on-insights-bookings branch from 3025103 to f6fcf0a Compare February 10, 2025 10:08
@eunjae-lee
Copy link
Copy Markdown
Contributor Author

eunjae-lee commented Feb 10, 2025

Feel free to approve this, but please do not auto-merge this. I will merge it tomorrow morning and give it a test on the QA 🙌

hbjORbj
hbjORbj approved these changes Feb 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working well. LGTM!

@hbjORbj
Copy link
Copy Markdown
Contributor

hbjORbj commented Feb 10, 2025

There's a type check error. I will update branch just in case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hbjORbj hbjORbj hbjORbj approved these changes

Assignees

No one assigned

Labels

consumer core area: core, team members only insights area: insights, analytics ready-for-e2e routing-forms area: routing forms, routing, forms

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eunjae-lee @hbjORbj @keithwillcode @PeerRich