perf: remove WithLayout from more App Router routes#19036
Merged
Conversation
dosubot
Bot
added
the
performance
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/31/25)1 reviewer was added to this PR based on Keith Williams's automation. |
hbjORbj
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hbjORbj
commented
Jan 31, 2025
Comment on lines
-12
to
-16
| if (session) { | ||
| return { | ||
| redirect: { destination: "/" }, | ||
| }; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
this can be handled directly in RSC in /auth/signin/page.tsx
Comment on lines
+18
to
+21
| const session = await getServerSession({ req: context.req }); | ||
| if (session) { | ||
| redirect("/"); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
logic tranferred from @server/lib/auth/signin/getServerSideProps
Contributor
E2E results are ready! |
PeerRich
approved these changes
Jan 31, 2025
PeerRich
deleted the
perf/remove-WithLayout-from-more-app-router-routes
branch
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
WithLayoutand relying on a single layout file ((use-page-wrapper)/layout.tsx). We need to migrate all routes that useWithLayoutinto(use-page-wrapper)route group.Mandatory Tasks (DO NOT REMOVE)