Skip to content

perf: move /teams page to (use-page-wrapper)/(main-nav) route group to use its shared layout#19037

Merged
PeerRich merged 1 commit intomainfrom
perf/move-teams-page-to-main-nav-route-group
Jan 31, 2025
Merged

perf: move /teams page to (use-page-wrapper)/(main-nav) route group to use its shared layout#19037
PeerRich merged 1 commit intomainfrom
perf/move-teams-page-to-main-nav-route-group

Conversation

@hbjORbj
Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj commented Jan 31, 2025 •
edited
Loading

What does this PR do?

  • /teams was rendering Shell in its client component. By moving this route inside (use-page-wrapper)/(main-nav), Shell is rendered from (use-page-wrapper)/(main-nav)/layout.tsx file and we render the team route's ShellMain in RSC (/teams/page.tsx)
  • Follow up of perf: layout persistence and reduced bundle size #18889

Tested

Screenshot 2025-01-31 at 13 00 31 Screenshot 2025-01-31 at 12 59 44

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Test /teams

@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 31, 2025
@dosubot dosubot Bot added performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive teams area: teams, round robin, collective, managed event-types labels Jan 31, 2025
@graphite-app graphite-app Bot requested a review from a team January 31, 2025 17:50
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jan 31, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/31/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 5:57pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Jan 31, 2025 5:57pm
calcom-web-canary ⬜️ Ignored (Inspect) Jan 31, 2025 5:57pm

@hbjORbj hbjORbj changed the title perf: move teams page to main nav route group perf: move /teams page to (use-page-wrapper)/(main-nav) route group to use its shared layout file Jan 31, 2025
@hbjORbj hbjORbj changed the title perf: move /teams page to (use-page-wrapper)/(main-nav) route group to use its shared layout file perf: move /teams page to (use-page-wrapper)/(main-nav) route group to use its shared layout Jan 31, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 31, 2025

E2E results are ready!

@PeerRich PeerRich merged commit 8dd05dd into main Jan 31, 2025
@PeerRich PeerRich deleted the perf/move-teams-page-to-main-nav-route-group branch January 31, 2025 20:12
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
@hbjORbj @MuhammadAimanSulaiman
perf: move /teams route to (main-nav) route group (calcom#19037)
1cad724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeerRich PeerRich PeerRich approved these changes

Assignees

No one assigned

Labels

consumer core area: core, team members only performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive ready-for-e2e teams area: teams, round robin, collective, managed event-types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hbjORbj @PeerRich @keithwillcode