Skip to content

fix: username visible in private booking link#19054

Merged
hbjORbj merged 2 commits intomainfrom
fix/username-visible-in-private-booking-link
Feb 3, 2025
Merged

fix: username visible in private booking link#19054
hbjORbj merged 2 commits intomainfrom
fix/username-visible-in-private-booking-link

Conversation

@hbjORbj
Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj commented Feb 2, 2025 •
edited
Loading

What does this PR do?

  • Fixes CAL-5110
  • The main purpose of single-use private links is to conceal the username from potential attendees, but they can still click your avatar to access the public page, which displays the username in the address bar.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Visit private booking links and hover the Avatar. It shouldn't have a link attached to it.
Screenshot 2025-02-01 at 7 16 04 PM

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 4:30am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 4:30am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 4:30am

@graphite-app graphite-app Bot requested a review from a team February 2, 2025 00:20
@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 2, 2025
@dosubot dosubot Bot added bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working labels Feb 2, 2025
@linear
Copy link
Copy Markdown

linear Bot commented Feb 2, 2025

CAL-5110 Single use private links avatar still clickable.

@hbjORbj hbjORbj enabled auto-merge (squash) February 2, 2025 00:24
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Feb 2, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/02/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2025 •
edited
Loading

E2E results are ready!

@hbjORbj hbjORbj merged commit ca650ba into main Feb 3, 2025
@hbjORbj hbjORbj deleted the fix/username-visible-in-private-booking-link branch February 3, 2025 05:36
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
@hbjORbj @MuhammadAimanSulaiman
fix: username is visible in private booking link (calcom#19054)
4934e44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pumfleet pumfleet pumfleet approved these changes

Assignees

No one assigned

Labels

bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working consumer core area: core, team members only ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hbjORbj @pumfleet @keithwillcode