Skip to content

feat: add option to disable sending transcription emails#19065

Merged
emrysal merged 8 commits intomainfrom
feat/disable-transcription
Feb 7, 2025
Merged

feat: add option to disable sending transcription emails#19065
emrysal merged 8 commits intomainfrom
feat/disable-transcription

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar commented Feb 3, 2025

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Add option to disable sending cal video transcription emails
Screenshot 2025-02-03 at 11 59 48 PM

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Go to event type advanced settings

@github-actions github-actions Bot added the ❗️ migrations contains migration files label Feb 3, 2025
@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Feb 3, 2025
@dosubot dosubot Bot added the ✨ feature New feature or request label Feb 3, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 0:20am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 0:20am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 0:20am

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Feb 3, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/03/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@Udit-takkar Udit-takkar added this to the v5.0 milestone Feb 4, 2025
alishaz-polymath

This comment was marked as outdated.

Copy link
Copy Markdown
Member

@alishaz-polymath alishaz-polymath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's do the follow up as we discussed on slack!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2025

E2E results are ready!

Copy link
Copy Markdown
Member

@alishaz-polymath alishaz-polymath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Not entirely sure how to test it locally from e2e.

@Udit-takkar Udit-takkar enabled auto-merge (squash) February 6, 2025 12:14
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 7, 2025

You must have Developer access to commit code to cal on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

requiresConfirmationWillBlockSlot Boolean @default(false)
requiresConfirmationForFreeEmail Boolean @default(false)
requiresBookerEmailVerification Boolean @default(false)
canSendCalVideoTranscriptionEmails Boolean @default(true)
Copy link
Copy Markdown
Contributor

@ThyMinimalDev ThyMinimalDev Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding this updates automatically the zod schema used by the trpc update handler correct ?

Copy link
Copy Markdown
Contributor

@ThyMinimalDev ThyMinimalDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emrysal emrysal disabled auto-merge February 7, 2025 11:47
@emrysal emrysal enabled auto-merge (squash) February 7, 2025 12:19
@emrysal emrysal merged commit 808de26 into main Feb 7, 2025
@emrysal emrysal deleted the feat/disable-transcription branch February 7, 2025 12:33
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
* feat: add option to disable sending transcription emails

* fix: types and tests

* fix: type error

* fix: type err

* fix: type err

---------

Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Co-authored-by: Keith Williams <keithwillcode@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ✨ feature New feature or request ❗️ migrations contains migration files ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants