test: Scenario that replicates the crash in production#19071
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
|
Hariom Balhara seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
hariombalhara
changed the title
keithwillcode
added
core
hariombalhara
commented
Feb 4, 2025
| organizerTimeZone: eventTimeZone, | ||
| datesOutOfOffice: !isTeamEvent ? allUsersAvailability[0]?.datesOutOfOffice : undefined, | ||
| datesOutOfOffice: { | ||
| "2020-06-01": { |
Member
Author
There was a problem hiding this comment.
This is a an old date before current time causing the error.
emrysal
changed the title
Contributor
|
Hi @hariombalhara I'd love to merge this test if it passes when the cause of crash is reverted. So we cover this scenario the next time. |
hariombalhara
force-pushed
the
crash-test
branch
from
ddb8312 to
9d16070
Compare
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/07/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (02/07/25)1 label was added to this PR based on Keith Williams's automation. |
Member
Author
|
@emrysal Done |
Contributor
E2E results are ready! |
This was referenced Feb 11, 2025
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
* Add a case that crashes * Add proper crash test case --------- Co-authored-by: Hariom Balhara <hariombalhara@gmgmail.com> Co-authored-by: Alex van Andel <me@alexvanandel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a test that identifies the crash scenario due to which we had to revert https://github.com/calcom/cal.com/pull/18054/files#diff-3bcd8b09138a03622b300b58836dfed0598874aed41ff92f57c2b2700f30f4b5