chore: migrate api/cancel to App Router#19074
Merged
Conversation
hbjORbj
added
high-risk
dosubot
Bot
added
api
hbjORbj
added
consumer
and removed
bookings
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/04/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (02/04/25)1 reviewer was added to this PR based on Keith Williams's automation. |
Contributor
E2E results are ready! |
hbjORbj
force-pushed
the
chore/migrate-api-cancel
branch
from
311757e to
382d40f
Compare
joeauyeung
approved these changes
Feb 5, 2025
emrysal
reviewed
Feb 6, 2025
| return NextResponse.json(result, { status: statusCode }); | ||
| } | ||
|
|
||
| export async function DELETE(req: NextRequest) { |
Contributor
There was a problem hiding this comment.
NIT, but I like this pattern:
Suggested change
| export async function DELETE(req: NextRequest) { | |
| export { | |
| handler as DELETE, | |
| handler as POST | |
| }; |
emrysal
approved these changes
Feb 6, 2025
Contributor
emrysal
left a comment
emrysal
left a comment
There was a problem hiding this comment.
Very minor NIT, non-blocking, just for future ref.
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
* Add app/api/cancel/route.ts * remove pages router api/cancel * refactors needed * refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
/api/cancel.tsto App RouterTested
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
/api/cancelrequest)