Skip to content

fix: check searchParams existence#19128

Merged
eunjae-lee merged 1 commit intomainfrom
fix/check-search-params-existence
Feb 6, 2025
Merged

fix: check searchParams existence#19128
eunjae-lee merged 1 commit intomainfrom
fix/check-search-params-existence

Conversation

@eunjae-lee
Copy link
Copy Markdown
Contributor

@eunjae-lee eunjae-lee commented Feb 6, 2025 •
edited
Loading

What does this PR do?

Check if searchParame exists.

This didn't fail the web deployment, but failed the docker deployment due to TS version difference.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 10:03am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 10:03am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 10:03am

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 6, 2025
@eunjae-lee eunjae-lee force-pushed the fix/check-search-params-existence branch from 4e9e181 to 7fc62b6 Compare February 6, 2025 09:49
@eunjae-lee eunjae-lee marked this pull request as ready for review February 6, 2025 09:50
@graphite-app graphite-app Bot requested a review from a team February 6, 2025 09:50
@dosubot dosubot Bot added bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working labels Feb 6, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Feb 6, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/06/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (02/06/25)

1 label was added to this PR based on Keith Williams's automation.

alishaz-polymath
alishaz-polymath approved these changes Feb 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@alishaz-polymath alishaz-polymath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eunjae-lee eunjae-lee enabled auto-merge (squash) February 6, 2025 10:01
@eunjae-lee eunjae-lee merged commit 4c32d0c into main Feb 6, 2025
@eunjae-lee eunjae-lee deleted the fix/check-search-params-existence branch February 6, 2025 10:28
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 6, 2025

E2E results are ready!

MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
@eunjae-lee @MuhammadAimanSulaiman
fix: check searchParams existence (calcom#19128)
4a2b9ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alishaz-polymath alishaz-polymath alishaz-polymath approved these changes

Assignees

No one assigned

Labels

bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working consumer core area: core, team members only ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eunjae-lee @alishaz-polymath @keithwillcode