Skip to content

chore: refactor apiRouteMiddleware and add it to some api routes in App Router#19146

Merged
hbjORbj merged 4 commits intomainfrom
chore/remove-try-and-catch-from-api-routes
Feb 7, 2025
Merged

chore: refactor apiRouteMiddleware and add it to some api routes in App Router#19146
hbjORbj merged 4 commits intomainfrom
chore/remove-try-and-catch-from-api-routes

Conversation

@hbjORbj
Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj commented Feb 6, 2025

What does this PR do?

  • refactor apiRouteMiddleware and add it to some api routes in App Router

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 6, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 0:31am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 0:31am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 0:31am

@dosubot dosubot Bot added the api area: API, enterprise API, access token, OAuth label Feb 6, 2025
@graphite-app graphite-app Bot requested a review from a team February 6, 2025 23:42
@hbjORbj hbjORbj force-pushed the chore/remove-try-and-catch-from-api-routes branch from c865754 to 10503fd Compare February 6, 2025 23:43
@hbjORbj hbjORbj changed the title chore: remove try and catch from api routes chore: remove try and catch from api routes in app router Feb 6, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Feb 6, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/06/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj changed the title chore: remove try and catch from api routes in app router chore: ensure app router api routes errors get logged to Sentry Feb 6, 2025
@hbjORbj hbjORbj marked this pull request as draft February 6, 2025 23:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 7, 2025

E2E results are ready!

@hbjORbj hbjORbj changed the title chore: ensure app router api routes errors get logged to Sentry chore: refactor apiRouteMiddleware Feb 7, 2025
@hbjORbj hbjORbj changed the title chore: refactor apiRouteMiddleware chore: refactor apiRouteMiddleware and add it to some api routes in App Router Feb 7, 2025
@hbjORbj hbjORbj marked this pull request as ready for review February 7, 2025 00:48
@dosubot dosubot Bot added the 💻 refactor label Feb 7, 2025
@hbjORbj hbjORbj enabled auto-merge (squash) February 7, 2025 00:55
Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hbjORbj hbjORbj merged commit e79af63 into main Feb 7, 2025
@hbjORbj hbjORbj deleted the chore/remove-try-and-catch-from-api-routes branch February 7, 2025 11:04
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
… App Router (calcom#19146)

* chore: remove try and catch from api routes in app router

* refactor

* refactor apiRouteMiddleware

* refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api area: API, enterprise API, access token, OAuth consumer core area: core, team members only ready-for-e2e 💻 refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants