Skip to content

chore: remove unneeded props from AuthContainer and make its usages cleaner#19191

Merged
hbjORbj merged 2 commits intomainfrom
chore/refactor-AuthContainer
Feb 12, 2025
Merged

chore: remove unneeded props from AuthContainer and make its usages cleaner#19191
hbjORbj merged 2 commits intomainfrom
chore/refactor-AuthContainer

Conversation

@hbjORbj
Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj commented Feb 8, 2025 •
edited
Loading

What does this PR do?

  • AuthContainers are now all used by app router routes (and hence props like isAppDir, title, and description can be removed)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@graphite-app graphite-app Bot requested a review from a team February 8, 2025 02:39
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 2:52am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2025 2:52am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2025 2:52am

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 8, 2025
@dosubot dosubot Bot added authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in 💻 refactor labels Feb 8, 2025
@hbjORbj hbjORbj changed the title chore: refactor authcontainer chore: remove unneeded props from AuthContainer and make its usages cleaner Feb 8, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Feb 8, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/08/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 8, 2025

E2E results are ready!

eunjae-lee
eunjae-lee approved these changes Feb 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@hbjORbj hbjORbj merged commit 4f226cd into main Feb 12, 2025
@hbjORbj hbjORbj deleted the chore/refactor-AuthContainer branch February 12, 2025 10:19
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
@hbjORbj @MuhammadAimanSulaiman
chore: remove unneeded props from AuthContainer and make its usages…
1b3d72b 
… cleaner (calcom#19191)

* refactor AuthContainer by removing app-dir related props

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eunjae-lee eunjae-lee eunjae-lee approved these changes

Assignees

No one assigned

Labels

authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in consumer core area: core, team members only ready-for-e2e 💻 refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hbjORbj @eunjae-lee @keithwillcode