fix: the set as default apps issue with links #19176

[PAVANNAIK25]

What does this PR do?

• Fixes [CAL-5137] Mirotalk app not recognizing Link #19176
• Fixes CAL-5137

Loom Video:
https://www.loom.com/share/0f6e8a0561174216abba9e22bc23035b?sid=39a5a0ad-cc1a-4988-abe4-153735ac32c3

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox. N/A
• I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

• Are there environment variables that should be set?
  • No.
• What are the minimal test data to have?
  • Installed apps conferencing should have Mirotalk installed.
• What is expected (happy path) to have (input and output)?
• I/P: set the default app as Mirotalk. O/P it should be set to default.
• Any other important info that could help to test that PR
  • Issue was regarding conference apps set as default. Apps which needs the links to set as default (example: mirotalk, discord, etc) was throwing error as "App link is required". This PR fixes the issue and fixed the issue with set as default.

[vercel]

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[graphite-app]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/08/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/08/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (02/10/25)

1 label was added to this PR based on Keith Williams's automation.

[retrogtx]

Hey @PAVANNAIK25

Thank you for the PR, it works. Could you please also implement the period and underscore check for links so that they get allowed?

[PAVANNAIK25]

Hi @retrogtx,

I have noticed that the issue affects all apps that require a link to be set as default. The current regex validation only allows uppercase letters, lowercase letters, and numbers, but it does not permit (.) or (_). Additionally, I would like to clarify whether we should also allow (-), as apps like Mirotalk allow users to create links with (-) as well. Should I include (-) in the validation?

[retrogtx]

Hi @retrogtx,

I have noticed that the issue affects all apps that require a link to be set as default. The current regex validation only allows uppercase letters, lowercase letters, and numbers, but it does not permit (.) or (_). Additionally, I would like to clarify whether we should also allow (-), as apps like Mirotalk allow users to create links with (-) as well. Should I include (-) in the validation?

please do, I will test the changes then

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Pavan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[retrogtx]

thank you tonnes, can you update the loom video for the same with the - examples?

[PAVANNAIK25]

thank you tonnes, can you update the loom video for the same with the - examples?

Loom Video:
https://www.loom.com/share/0469cc33131e4fe5ad893b5f3b73e35f?sid=a79172a1-2053-4b22-ab6e-7d8c47c5bc61

[retrogtx]

tested, works

[retrogtx]

thank you tonnes, can you update the loom video for the same with the - examples?

Loom Video: https://www.loom.com/share/0469cc33131e4fe5ad893b5f3b73e35f?sid=a79172a1-2053-4b22-ab6e-7d8c47c5bc61

please sign the CLA so that we can merge this 🙏

[PAVANNAIK25]

please sign the CLA so that we can merge this 🙏

I have already singed it. Please merge this request.

[github-actions]

E2E results are ready!

• Workflow #47031.1 latest results