Skip to content

fix: select "Your account" for members by default on insights#19236

Merged
emrysal merged 1 commit intomainfrom
fix/org-team-filter-for-members
Feb 11, 2025
Merged

fix: select "Your account" for members by default on insights#19236
emrysal merged 1 commit intomainfrom
fix/org-team-filter-for-members

Conversation

@eunjae-lee
Copy link
Copy Markdown
Contributor

@eunjae-lee eunjae-lee commented Feb 11, 2025

What does this PR do?

The new OrgTeamsFilter chose "All" wrongly when the user is a member. This PR fixes it.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Go to /insights or /insights/routing as a member. It should select "Your account" by default.

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 10:22am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Feb 11, 2025 10:22am
calcom-web-canary ⬜️ Ignored (Inspect) Feb 11, 2025 10:22am

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 11, 2025
@eunjae-lee eunjae-lee marked this pull request as ready for review February 11, 2025 10:22
@graphite-app graphite-app Bot requested a review from a team February 11, 2025 10:23
@dosubot dosubot Bot added insights area: insights, analytics 🐛 bug Something isn't working labels Feb 11, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Feb 11, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/11/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (02/11/25)

1 label was added to this PR based on Keith Williams's automation.

imageSrc={getPlaceholderAvatar(team.logoUrl, team.name)}
size="xs"
/>
{teams.length > 0 && <Divider />}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are mostly indentation change.

turn this on for better diff:
Screenshot 2025-02-11 at 11 25 08

@emrysal emrysal enabled auto-merge (squash) February 11, 2025 12:19
@emrysal emrysal merged commit 5a602f1 into main Feb 11, 2025
@emrysal emrysal deleted the fix/org-team-filter-for-members branch February 11, 2025 12:39
@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working consumer core area: core, team members only insights area: insights, analytics ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants