fix: Salesforce bugs#19250
Merged
Udit-takkar merged 4 commits intomainfrom Feb 12, 2025
Merged
Conversation
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/11/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (02/11/25)1 label was added to this PR based on Keith Williams's automation. |
dosubot
Bot
added
crm-apps
emrysal
reviewed
Feb 11, 2025
| ); | ||
|
|
||
| if (contactsQuery.records.length) { | ||
| if (contactsQuery.records.length > 0) { |
Contributor
There was a problem hiding this comment.
Instead of an if statement this is the ideal place to extract into a sub function :)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
emrysal
approved these changes
Feb 11, 2025
Contributor
emrysal
left a comment
emrysal
left a comment
There was a problem hiding this comment.
Clean! 🚀 well done fixup
Contributor
E2E results are ready! |
Udit-takkar
approved these changes
Feb 12, 2025
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
* incompleteBooking only search for leads if contact is not found * Fix logic * Abstract to functions --------- Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?