fix: decode params used in query object in buildLegacyCtx#19253
Merged
fix: decode params used in query object in buildLegacyCtx#19253
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
hbjORbj
changed the title
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/12/25)1 reviewer was added to this PR based on Keith Williams's automation. |
anikdhabal
previously approved these changes
Feb 12, 2025
anikdhabal
approved these changes
Feb 12, 2025
Contributor
E2E results are ready! |
Udit-takkar
reviewed
Feb 12, 2025
| ) => { | ||
| return { | ||
| query: { ...searchParams, ...params }, | ||
| query: { ...searchParams, ...decodeParams(params) }, |
Contributor
There was a problem hiding this comment.
we actually don't allow special characters in username
Contributor
There was a problem hiding this comment.
Not sure if we want this or not, but currently it's possible to save special characters in a username. I just changed a user's username from franz-janssen to franz-janßen on prod
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
* fix: decode params used in query object in buildLegacyCtx * add tests * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?