Skip to content

fix: indicate hidden columns on filter dropdown#19259

Merged
sean-brydon merged 2 commits intomainfrom
eunjae/cal-5159-indicate-hidden-columns-on-filter-dropdown-menu
Feb 12, 2025
Merged

fix: indicate hidden columns on filter dropdown#19259
sean-brydon merged 2 commits intomainfrom
eunjae/cal-5159-indicate-hidden-columns-on-filter-dropdown-menu

Conversation

@eunjae-lee
Copy link
Copy Markdown
Contributor

What does this PR do?

  • Fixes CAL-5159

Even if you hide columns, you can still filter based on those columns. However, it'd be nicer to have an indicator that the column is currently hidden.

Screenshot.2025-02-12.at.13.34.46.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@linear
Copy link
Copy Markdown

linear Bot commented Feb 12, 2025

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 1:45pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 1:45pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 1:45pm

@eunjae-lee eunjae-lee marked this pull request as ready for review February 12, 2025 12:47
@graphite-app graphite-app Bot requested a review from a team February 12, 2025 12:47
@dosubot dosubot Bot added the 🐛 bug Something isn't working label Feb 12, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Feb 12, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/12/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (02/12/25)

1 label was added to this PR based on Keith Williams's automation.

sean-brydon
sean-brydon previously approved these changes Feb 12, 2025
@sean-brydon sean-brydon enabled auto-merge (squash) February 12, 2025 12:53
@sean-brydon sean-brydon merged commit 06bf9cf into main Feb 12, 2025
@sean-brydon sean-brydon deleted the eunjae/cal-5159-indicate-hidden-columns-on-filter-dropdown-menu branch February 12, 2025 13:33
@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working consumer core area: core, team members only ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants