fix: #19296 Success pages shows wrong nr of occurrences (recurring booking)

[PAVANNAIK25]

What does this PR do?

• Fixes [CAL-5169] Success pages shows wrong nr of occurrences (recurring booking) #19296
• Fixes CAL-[5169]

Loom Video: https://www.loom.com/share/56386d96f91c4104abc11a4ceba27ca1?sid=93fdc459-4cc2-4451-ae54-bfe9dfab8725

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox. N/A
• I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

• Are there environment variables that should be set?
  • No
• What are the minimal test data to have?
  • You must have at least one recurring event with to book. It must be requires confirmation toggle on.
• What is expected (happy path) to have (input and output)?
  • Booking is successful with list of occurrences.
• Any other important info that could help to test that PR
  • Please refer Loom video.

[vercel]

@PAVANNAIK25 is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "fix #19296 Success pages shows wrong nr of occurrences (recurring booking)". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

[graphite-app]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/15/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/15/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (02/21/25)

1 label was added to this PR based on Keith Williams's automation.

[TusharBhatt1]

Can you add a loom to reproduce the issue

[PAVANNAIK25]

Can you add a loom to reproduce the issue

Sure

[PAVANNAIK25]

Loom Video:
https://www.loom.com/share/716fa3c8e0b649cfa9fc5b4f2e2946b6?sid=2efa5478-b8eb-4cd8-bfc8-4b841c483db0

[TusharBhatt1]

Loom Video: https://www.loom.com/share/716fa3c8e0b649cfa9fc5b4f2e2946b6?sid=2efa5478-b8eb-4cd8-bfc8-4b841c483db0

Works well for me (had max - 12 , booked - 10 , got - 10 ) :

Or I am missing something

[PAVANNAIK25]

Works well for me (had max - 12 , booked - 10 , got - 10 ) :

Or I am missing something

No. It was issue on a success page. It worked correctly in your screenshot.

[TusharBhatt1]

Thanks for the contribution , as witnessed it's already working as expected.

[TusharBhatt1]

Issue when Required Confirmation is true , re reviewing

[TusharBhatt1]

Works well for me (had max - 12 , booked - 10 , got - 10 ) :

Or I am missing something

No. It was issue on a success page. It worked correctly in your screenshot.

[TusharBhatt1]

Loom Video: https://www.loom.com/share/716fa3c8e0b649cfa9fc5b4f2e2946b6?sid=2efa5478-b8eb-4cd8-bfc8-4b841c483db0

While booking getting : 500 {"message":"Invalid key length"}
When clicking again getting : 409 {"message":"booking_conflicts"}

Something's off

[PAVANNAIK25]

While booking getting : 500 {"message":"Invalid key length"} When clicking again getting : 409 {"message":"booking_conflicts"}

Something's off

The error is due to the email sending behavior. Once the booking is confirm it will send email to organizer to confirm booking.
Either you need to setup a email in local development or you can comment below code. It will work in production since there the email setup is there.

[TusharBhatt1]

While booking getting : 500 {"message":"Invalid key length"} When clicking again getting : 409 {"message":"booking_conflicts"}
Something's off

The error is due to the email sending behavior. Once the booking is confirm it will send email to organizer to confirm booking. Either you need to setup a email in local development or you can comment below code. It will work in production since there the email setup is there.

Fine , but it has to be tested

[TusharBhatt1]

Tested , work well !

[github-actions]

E2E results are ready!

• Workflow #48440.1 latest results