fix: booking fields being overridden whenever saving with atom#19339
Merged
fix: booking fields being overridden whenever saving with atom#19339
Conversation
keithwillcode
added
core
dosubot
Bot
added
event-types
supalarry
requested changes
Feb 19, 2025
| if ( | ||
| !bookingFields.find((field) => field.type === "email") && | ||
| !bookingFields.find((field) => field.type === "phone") | ||
| ) { |
Contributor
There was a problem hiding this comment.
I think instead of removing code we need to modify it - the removed code exists to ensure that if booking fields are passed that either email or phone fields are defined, because if none of them are defined then the updateEventType from platform libraries which is this function packages/trpc/server/routers/viewer/eventTypes/update.handler.ts will fail because of check ensureEmailOrPhoneNumberIsPresent.
Instead we need to say - ensure that email or phone is present only if body.bookingFields are provided.
await this.checkCanUpdateTeamEventType(user.id, eventTypeId, teamId, body.scheduleId);
const eventTypeUser = await this.eventTypeService.getUserToUpdateEvent(user);
const bookingFields = body.bookingFields ? [...body.bookingFields] : undefined;
if (
bookingFields?.length &&
!bookingFields.find((field) => field.type === "email") &&
!bookingFields.find((field) => field.type === "phone")
) {
bookingFields.push(systemBeforeFieldEmail);
}
const eventType = await updateEventType({
input: { id: eventTypeId, ...body, bookingFields },
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
supalarry
approved these changes
Feb 20, 2025
Graphite Automations"Add ready-for-e2e label" took an action on this PR • (02/20/25)1 label was added to this PR based on Keith Williams's automation. |
Contributor
E2E results are ready! |
Contributor
Author
|
tested it, good to merge :) |
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
…m#19339) * fix booking fields not saving properly * fixup
itsalam
pushed a commit
to itsalam/cal.com
that referenced
this pull request
Mar 6, 2025
…m#19339) * fix booking fields not saving properly * fixup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
This can be tested in the examples app for atoms