fix: preserve columnVisibility from initialState#19412
Merged
eunjae-lee merged 1 commit intomainfrom Feb 21, 2025
Merged
Conversation
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/20/25)1 reviewer was added to this PR based on Keith Williams's automation. |
hbjORbj
approved these changes
Feb 20, 2025
Contributor
E2E results are ready! |
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
itsalam
pushed a commit
to itsalam/cal.com
that referenced
this pull request
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR preserves columnVisibility from initialState.
initialState.columnVisibilityis only used untiltable.setOptions({ ... , columnVisibility })is called.Afterwards,
column.getIsVisible()refers to onlytable.options.state.So, in this PR, I merge the two, because sometimes we want to keep certain columns hidden.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
At /insights/routing, the first two columns should've been hidden. (Routing Forms, User)
This is the screenshot of the current prod version. They should be hidden in this branch.