Skip to content

chore: migrate saml/oidc APIs to App Router#19515

Merged
hbjORbj merged 15 commits intomainfrom
chore/migrate-api-saml-oidc
Mar 10, 2025
Merged

chore: migrate saml/oidc APIs to App Router#19515
hbjORbj merged 15 commits intomainfrom
chore/migrate-api-saml-oidc

Conversation

@hbjORbj
Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj commented Feb 24, 2025

What does this PR do?

  • Left a self review for easier review

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Please use the latest Vercel preview and test please 🙏.

@graphite-app graphite-app Bot requested a review from a team February 24, 2025 18:57
@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 24, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 1:47pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 1:47pm

@dosubot dosubot Bot added the authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in label Feb 24, 2025
@hbjORbj hbjORbj changed the title chore: migrate api saml oidc chore: migrate saml/oidc APIs to App Router Feb 24, 2025
@hbjORbj hbjORbj changed the title chore: migrate saml/oidc APIs to App Router chore: migrate saml/oidc api endpoints to App Router Feb 24, 2025
@hbjORbj hbjORbj changed the title chore: migrate saml/oidc api endpoints to App Router chore: migrate saml/oidc APIs to App Router Feb 24, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Feb 24, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/24/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (02/26/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@@ -0,0 +1,41 @@
import type { NextRequest } from "next/server";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff compared to original api code

Screenshot 2025-02-24 at 2 00 28 PM

@@ -0,0 +1,27 @@
import type { OAuthReq } from "@boxyhq/saml-jackson";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff compared to original api code

Screenshot 2025-02-24 at 2 01 18 PM

@@ -0,0 +1,15 @@
import type { NextRequest } from "next/server";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-02-24 at 2 01 46 PM

@@ -0,0 +1,36 @@
import type { NextRequest } from "next/server";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-02-24 at 2 02 29 PM

@@ -0,0 +1,21 @@
import type { NextRequest } from "next/server";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-02-24 at 2 03 02 PM

@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

@hbjORbj hbjORbj marked this pull request as ready for review February 26, 2025 12:53
@graphite-app graphite-app Bot requested a review from a team February 26, 2025 12:54
@hbjORbj hbjORbj marked this pull request as draft February 26, 2025 13:00
@hbjORbj hbjORbj marked this pull request as ready for review March 9, 2025 16:03
@hbjORbj hbjORbj requested review from sean-brydon and removed request for a team March 9, 2025 16:04
Copy link
Copy Markdown
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Another one :D

@hbjORbj hbjORbj enabled auto-merge (squash) March 10, 2025 13:42
@hbjORbj hbjORbj merged commit 8d18b3d into main Mar 10, 2025
@hbjORbj hbjORbj deleted the chore/migrate-api-saml-oidc branch March 10, 2025 14:36
ThyMinimalDev pushed a commit that referenced this pull request Mar 13, 2025
* migrate oidc

* migrate saml apis

* remove comment

* add force-dynamic

* fix

* fix

* refactor

---------

Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in consumer core area: core, team members only ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants