Skip to content

feat: booking redirect page url is now has uid in it's parameters#19522

Merged
PeerRich merged 7 commits intocalcom:mainfrom
retrogtx:uid-redirect
Mar 3, 2025
Merged

feat: booking redirect page url is now has uid in it's parameters#19522
PeerRich merged 7 commits intocalcom:mainfrom
retrogtx:uid-redirect

Conversation

@retrogtx
Copy link
Copy Markdown
Contributor

What does this PR do?

Adds UID in the redirect URL after the websites domain in the form of ?uid=youruidxyz

Loom Video: https://www.loom.com/share/d3286e56a7514d5a8f37539ac0b97a23?sid=8ff255d1-5274-4bfe-8c83-546d54e766d6

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 25, 2025

@retrogtx is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 25, 2025
@graphite-app graphite-app bot requested a review from a team February 25, 2025 03:46
@github-actions github-actions bot added booking-page area: booking page, public booking page, booker 🐛 bug Something isn't working labels Feb 25, 2025
@keithwillcode keithwillcode added the community-interns The team responsible for reviewing, testing and shipping low/medium community PRs label Feb 25, 2025
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking ✨ feature New feature or request labels Feb 25, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Feb 25, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/25/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/25/25)

1 label was added to this PR based on Keith Williams's automation.

@retrogtx retrogtx changed the title feat: booking redirect page is now w UID feat: booking redirect page url is now has uid in it's parameters Feb 25, 2025
Comment thread packages/lib/bookingSuccessRedirect.ts
Comment thread packages/lib/bookingSuccessRedirect.ts
Comment thread packages/lib/bookingSuccessRedirect.ts Outdated
@github-actions github-actions bot marked this pull request as draft February 25, 2025 12:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 25, 2025

E2E results are ready!

@retrogtx retrogtx requested a review from hbjORbj February 25, 2025 13:44
@retrogtx retrogtx marked this pull request as ready for review February 25, 2025 13:55
@PeerRich PeerRich enabled auto-merge (squash) March 3, 2025 08:02
Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAY better than the first draft of yours! Great job addressing all the comments.

@PeerRich PeerRich merged commit fd6effa into calcom:main Mar 3, 2025
33 of 37 checks passed
@retrogtx
Copy link
Copy Markdown
Contributor Author

retrogtx commented Mar 3, 2025

WAY better than the first draft of yours! Great job addressing all the comments.

thank you ☺️🙏

itsalam pushed a commit to itsalam/cal.com that referenced this pull request Mar 6, 2025
…lcom#19522)

* feat: booking redirect page is now w UID

* refactor: use getBookingRedirectExtraParams

* refactor: remove uncessary const result

* uid isnt the first param anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

booking-page area: booking page, public booking page, booker bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync community-interns The team responsible for reviewing, testing and shipping low/medium community PRs ✨ feature New feature or request ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-5213] booking ID not part of redirect URL param

5 participants