Skip to content

fix: scheduleId to work on PATCH event type host assignment via api v1#19546

Merged
anikdhabal merged 3 commits intocalcom:mainfrom
Shpadoinkle:fix/scheduleid-on-event-type-hosts-api-v1
Mar 3, 2025
Merged

fix: scheduleId to work on PATCH event type host assignment via api v1#19546
anikdhabal merged 3 commits intocalcom:mainfrom
Shpadoinkle:fix/scheduleid-on-event-type-hosts-api-v1

Conversation

@Shpadoinkle
Copy link
Copy Markdown
Contributor

What does this PR do?

Updates to api V1:

  • Event Type update
    • allows scheduledId to be passed in when setting hosts via the api
    • without passing this in. all hosts are saved as using their 'default' schedule, undoing previous configuration via the frontend.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Using the calcom frontend, set up a host on a Round robin using a custom schedule other than their default.

  • If you use the patch endpoint to set a host, passing in scheduleId using the current api is ignored. and the hosts will use their default schedule

  • If you use the patch endpoint using this change, then passing in a scheduleId will save it as expected

@Shpadoinkle Shpadoinkle requested a review from a team February 26, 2025 04:57
@vercel
Copy link
Copy Markdown

vercel bot commented Feb 26, 2025

@Shpadoinkle is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 26, 2025
@graphite-app graphite-app bot requested a review from a team February 26, 2025 04:58
@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working labels Feb 26, 2025
@Shpadoinkle Shpadoinkle changed the title fix: scheduledId to work on PATCH event type host assignment via api v1 fix: scheduleId to work on PATCH event type host assignment via api v1 Feb 26, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Feb 26, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/26/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/26/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (03/03/25)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Copy Markdown
Contributor

@retrogtx retrogtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a split from the other PR, so is this part done?

@Shpadoinkle
Copy link
Copy Markdown
Contributor Author

This is a split from the other PR, so is this part done?

@retrogtx this pr is separate, and does not require the other pr to be merged first.

Copy link
Copy Markdown
Member

@alishaz-polymath alishaz-polymath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@anikdhabal anikdhabal enabled auto-merge (squash) March 3, 2025 17:58
@anikdhabal anikdhabal merged commit 340f15f into calcom:main Mar 3, 2025
31 of 35 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2025

E2E results are ready!

itsalam pushed a commit to itsalam/cal.com that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working community Created by Linear-GitHub Sync ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants