perf: Remove PlainChat from pages router#19588
Merged
Conversation
hbjORbj
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
hbjORbj
changed the title
isPlainChatEnabled prop from /app/layout.tsx
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/26/25)1 reviewer was added to this PR based on Keith Williams's automation. |
hbjORbj
changed the title
isPlainChatEnabled prop from /app/layout.tsx
hbjORbj
changed the title
Contributor
E2E results are ready! |
zomars
reviewed
Feb 26, 2025
hbjORbj
changed the title
hbjORbj
force-pushed
the
chore/remove-PlainChat-from-pages-router
branch
from
a3b39c1 to
32c0e36
Compare
Contributor
Author
|
@zomars I reduced the scope of this PR to removing the component from pages router! safe to merge now |
zomars
approved these changes
Feb 27, 2025
itsalam
pushed a commit
to itsalam/cal.com
that referenced
this pull request
Mar 6, 2025
* chore: Remove PlainChat instance from pages router * do not dynamically import plain chat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PlainChatinstance from Pages Router as it's no longer needed (we already have an instance ofPlainChatin app router)Tested
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?