Skip to content

feat: make calcom UI dumb again#19658

Merged
keithwillcode merged 16 commits intomainfrom
feat/make-calcom-ui-dumb-again
Mar 5, 2025
Merged

feat: make calcom UI dumb again#19658
keithwillcode merged 16 commits intomainfrom
feat/make-calcom-ui-dumb-again

Conversation

@sean-brydon
Copy link
Copy Markdown
Member

What does this PR do?

Removes TRPC from all calcom ui components

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@keithwillcode keithwillcode added consumer core area: core, team members only labels Mar 3, 2025
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 2:26pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 2:26pm

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved timezone select into features/components a new place we can put organisms -> UI components that are more developed with api calls etc

@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 3, 2025

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

Copy link
Copy Markdown
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove from package.json and yarn.lock

@sean-brydon sean-brydon marked this pull request as ready for review March 4, 2025 08:16
@sean-brydon sean-brydon requested a review from a team March 4, 2025 08:16
@graphite-app graphite-app bot requested review from a team March 4, 2025 08:16
@dosubot dosubot bot added the ✨ feature New feature or request label Mar 4, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Mar 4, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/04/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (03/04/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode enabled auto-merge (squash) March 5, 2025 12:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2025

E2E results are ready!

@keithwillcode keithwillcode disabled auto-merge March 5, 2025 14:58
@keithwillcode keithwillcode merged commit 4cdb8f3 into main Mar 5, 2025
41 checks passed
@keithwillcode keithwillcode deleted the feat/make-calcom-ui-dumb-again branch March 5, 2025 14:58
itsalam pushed a commit to itsalam/cal.com that referenced this pull request Mar 6, 2025
* remove create button for teams from calcom ui

* migrate timezone select to features

* remove trpc from phone and storybook provider

* new-yarn.lock

* fix imports + test file for select

* fix platform timezone select to use Raw timezone select

* fix timezone type import

* use correct select in timezone-select.tsx - needs trpc version

* fix lock and remove test-utils

* fix log file

* Updated yarn.lock

* Fixed types

* Fixed tests

---------

Co-authored-by: Keith Williams <keithwillcode@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only ✨ feature New feature or request ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants