Skip to content

fix: use impersonatedById#19682

Merged
pumfleet merged 3 commits intomainfrom
chore/use-impersonated-id
Mar 5, 2025
Merged

fix: use impersonatedById#19682
pumfleet merged 3 commits intomainfrom
chore/use-impersonated-id

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar commented Mar 3, 2025 •
edited
Loading

What does this PR do?

  • Fixes #XXXX (GitHub issue number)

  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

  • Prefer using impersonatedBy user id to make sure we don't trigger automatic no show in case user was impersonating someone else

Visual Demo (For contributors especially)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

@graphite-app graphite-app bot requested a review from a team March 3, 2025 19:06
@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Mar 3, 2025
@Udit-takkar Udit-takkar added this to the v5.1 milestone Mar 3, 2025
@dosubot dosubot bot added the 🐛 bug Something isn't working label Mar 3, 2025
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 3:43pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 3:43pm

@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Mar 3, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/03/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (03/03/25)

1 label was added to this PR based on Keith Williams's automation.

pumfleet
pumfleet approved these changes Mar 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@pumfleet pumfleet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pumfleet pumfleet enabled auto-merge (squash) March 3, 2025 19:22
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2025 •
edited
Loading

E2E results are ready!

@pumfleet pumfleet merged commit b74a49f into main Mar 5, 2025
32 checks passed
@pumfleet pumfleet deleted the chore/use-impersonated-id branch March 5, 2025 15:43
itsalam pushed a commit to itsalam/cal.com that referenced this pull request Mar 6, 2025
@Udit-takkar @pumfleet @itsalam
fix: use impersonatedById (calcom#19682)
adb560a 
Co-authored-by: Bailey Pumfleet <bailey@pumfleet.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeerRich PeerRich PeerRich approved these changes

@pumfleet pumfleet pumfleet approved these changes

Assignees

No one assigned

Labels

🐛 bug Something isn't working core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e

Projects

None yet

Milestone

v5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Udit-takkar @PeerRich @pumfleet @keithwillcode